You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2024/02/18 09:44:38 UTC

Re: [PR] [Feature][Kafka] Support multi-table source read [seatunnel]

hailin0 commented on code in PR #5992:
URL: https://github.com/apache/seatunnel/pull/5992#discussion_r1493712989


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/serialization/DeserializationSchema.java:
##########
@@ -29,13 +30,15 @@ public interface DeserializationSchema<T> extends Serializable {
      * Deserializes the byte message.
      *
      * @param message The message, as a byte array.
+     * @param tablePath The Registry name.
      * @return The deserialized message as an SeaTunnel Row (null if the message cannot be
      *     deserialized).
      */
-    T deserialize(byte[] message) throws IOException;
+    T deserialize(byte[] message, TablePath tablePath) throws IOException;

Review Comment:
   Why add it here, it's pretty destructive
   
   cc @Hisoka-X @EricJoy2048 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org