You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2008/05/19 04:28:32 UTC
IConverterLocator generics broken
public interface IConverterLocator<T> extends IClusterable
{
public IConverter<T> getConverter(Class<T> type);
}
doesnt make any sense, it should be
public interface IConverterLocato extends IClusterable
{
public <T> IConverter<T> getConverter(Class<T> type);
}
objections? johan you want to make that change since you worked on
converter generics?
Re: IConverterLocator generics broken
Posted by Frank Bille <fr...@apache.org>.
Is this a showstopper for m2?
Frank
On Mon, May 19, 2008 at 4:28 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> public interface IConverterLocator<T> extends IClusterable
> {
> public IConverter<T> getConverter(Class<T> type);
> }
>
> doesnt make any sense, it should be
>
> public interface IConverterLocato extends IClusterable
> {
> public <T> IConverter<T> getConverter(Class<T> type);
> }
>
> objections? johan you want to make that change since you worked on
> converter generics?
>
Re: IConverterLocator generics broken
Posted by Johan Compagner <jc...@gmail.com>.
I thought it would break yes.
Will try to look at it, but i gues this will not be a really easy
change because component<T> isnt converter<T> any more.
On 5/19/08, Igor Vaynberg <ig...@gmail.com> wrote:
> i tried it real quick and it breaks Component. i havent had time to
> try and fix it and going to be pretty busy tomorow, so if you have
> time give it a shot, if not i will when i get a chance.
>
> -igor
>
>
> On Sun, May 18, 2008 at 11:58 PM, Johan Compagner <jc...@gmail.com>
> wrote:
>> You can make that change, if you want.
>> Does it all compile if you change that?
>>
>> On 5/19/08, Igor Vaynberg <ig...@gmail.com> wrote:
>>> public interface IConverterLocator<T> extends IClusterable
>>> {
>>> public IConverter<T> getConverter(Class<T> type);
>>> }
>>>
>>> doesnt make any sense, it should be
>>>
>>> public interface IConverterLocato extends IClusterable
>>> {
>>> public <T> IConverter<T> getConverter(Class<T> type);
>>> }
>>>
>>> objections? johan you want to make that change since you worked on
>>> converter generics?
>>>
>>
>
Re: IConverterLocator generics broken
Posted by Igor Vaynberg <ig...@gmail.com>.
i tried it real quick and it breaks Component. i havent had time to
try and fix it and going to be pretty busy tomorow, so if you have
time give it a shot, if not i will when i get a chance.
-igor
On Sun, May 18, 2008 at 11:58 PM, Johan Compagner <jc...@gmail.com> wrote:
> You can make that change, if you want.
> Does it all compile if you change that?
>
> On 5/19/08, Igor Vaynberg <ig...@gmail.com> wrote:
>> public interface IConverterLocator<T> extends IClusterable
>> {
>> public IConverter<T> getConverter(Class<T> type);
>> }
>>
>> doesnt make any sense, it should be
>>
>> public interface IConverterLocato extends IClusterable
>> {
>> public <T> IConverter<T> getConverter(Class<T> type);
>> }
>>
>> objections? johan you want to make that change since you worked on
>> converter generics?
>>
>
Re: IConverterLocator generics broken
Posted by Johan Compagner <jc...@gmail.com>.
You can make that change, if you want.
Does it all compile if you change that?
On 5/19/08, Igor Vaynberg <ig...@gmail.com> wrote:
> public interface IConverterLocator<T> extends IClusterable
> {
> public IConverter<T> getConverter(Class<T> type);
> }
>
> doesnt make any sense, it should be
>
> public interface IConverterLocato extends IClusterable
> {
> public <T> IConverter<T> getConverter(Class<T> type);
> }
>
> objections? johan you want to make that change since you worked on
> converter generics?
>