You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "cbolgiano (GitHub)" <gi...@apache.org> on 2018/10/08 15:04:16 UTC
[GitHub] [incubator-dubbo] cbolgiano opened pull request #2609:
Dubbo-2605 Removed java9 from .travis.yml
## What is the purpose of the change
To fix issue 2605 by removing jdk9 from .travis.yml.
## Brief changelog
commit 99babae7ff6e947059fee14cc2425aead46e6be8 (HEAD -> remove-javatr
avis-issue-2605, origin/remove-java9-travis-issue-2605)
Author: devbox <cb...@gmail.com>
Date: Mon Oct 8 10:38:47 2018 -0400
Removed jdk9 from .travis.yml.
## Verifying this change
I do not have a local copy of travis ci. I can add the results from travis ci as a comment in the PR after it is created.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
^No tests written for this small contribution.
- [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
^ both tasks fail on branch 2.6.x
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
^ This is a small contribution.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2609 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] diecui1202 closed pull request #2609:
Dubbo-2605 Removed java9 from .travis.yml
Posted by "diecui1202 (GitHub)" <gi...@apache.org>.
[ pull request closed by diecui1202 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2609 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2609:
Dubbo-2605 Removed java9 from .travis.yml
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=h1) Report
> Merging [#2609](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/79ea2acba862ed31dec2615220e0accac49c3dfb?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #2609 +/- ##
============================================
- Coverage 47.53% 47.47% -0.07%
+ Complexity 4303 4300 -3
============================================
Files 557 557
Lines 24433 24406 -27
Branches 4349 4325 -24
============================================
- Hits 11615 11587 -28
+ Misses 11021 11017 -4
- Partials 1797 1802 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-8.75%)` | `19% <0%> (-2%)` | |
| [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9maXhlZC9GaXhlZFRocmVhZFBvb2wuamF2YQ==) | `80% <0%> (-7.5%)` | `3% <0%> (ø)` | |
| [.../threadpool/support/limited/LimitedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9saW1pdGVkL0xpbWl0ZWRUaHJlYWRQb29sLmphdmE=) | `83.33% <0%> (-5.56%)` | `3% <0%> (ø)` | |
| [...on/threadpool/support/cached/CachedThreadPool.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZHBvb2wvc3VwcG9ydC9jYWNoZWQvQ2FjaGVkVGhyZWFkUG9vbC5qYXZh) | `85.71% <0%> (-4.29%)` | `3% <0%> (ø)` | |
| [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvTG9nVGVsbmV0SGFuZGxlci5qYXZh) | `68.57% <0%> (-2.86%)` | `3% <0%> (ø)` | |
| [...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh) | `83.33% <0%> (-2.39%)` | `20% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailoverClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvRmFpbG92ZXJDbHVzdGVySW52b2tlci5qYXZh) | `81.81% <0%> (-2.28%)` | `7% <0%> (ø)` | |
| [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `87.85% <0%> (-1.87%)` | `15% <0%> (ø)` | |
| [...libaba/dubbo/remoting/transport/AbstractCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L0Fic3RyYWN0Q29kZWMuamF2YQ==) | `80% <0%> (-0.77%)` | `10% <0%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2609/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=footer). Last update [79ea2ac...99babae](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2609 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org