You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/04 05:02:11 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #20639: Clarify `sentry_on` value is not quoted with example

uranusjr commented on a change in pull request #20639:
URL: https://github.com/apache/airflow/pull/20639#discussion_r777826708



##########
File path: docs/apache-airflow/logging-monitoring/errors.rst
##########
@@ -29,13 +29,14 @@ First you must install sentry requirement:
 
    pip install 'apache-airflow[sentry]'
 
-After that, you need to enable the integration by set ``sentry_on`` option in ``[sentry]`` section to ``"True"``.
+After that, you need to enable the integration by set ``sentry_on`` option in ``[sentry]`` section to ``'True'``.

Review comment:
       +1 to removing quotes to both. These are INI, not Python, the quotes just shouldn’t exist in the first place.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org