You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/07 20:57:02 UTC

[GitHub] [maven-shade-plugin] johnmillner opened a new pull request #51: MSHADE-371 - Update Shade Apache[Notice/LISENCE]ResourceTransformer to use [NOTICE/LISENCE].md

johnmillner opened a new pull request #51:
URL: https://github.com/apache/maven-shade-plugin/pull/51


   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   for 
   * org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer
   * org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer
   there is no check for LISENCE.md or NOTICE.md 
   
   small PR wanted to add that in along with the checks for LISENCE/LISENCE.txt and NOTICE/NOTICE.txt 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] radio-rogal commented on pull request #51: [MSHADE-371] Update Shade Apache[Notice/LICENSE] ResourceTransformer to use [NOTICE/LICENSE].md

Posted by GitBox <gi...@apache.org>.
radio-rogal commented on pull request #51:
URL: https://github.com/apache/maven-shade-plugin/pull/51#issuecomment-1001168329


   Could you reopen this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] johnmillner commented on pull request #51: MSHADE-371 - Update Shade Apache[Notice/LISENCE]ResourceTransformer to use [NOTICE/LISENCE].md

Posted by GitBox <gi...@apache.org>.
johnmillner commented on pull request #51:
URL: https://github.com/apache/maven-shade-plugin/pull/51#issuecomment-640279945


   https://issues.apache.org/jira/browse/MSHADE-371


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] radio-rogal edited a comment on pull request #51: [MSHADE-371] Update Shade Apache[Notice/LICENSE] ResourceTransformer to use [NOTICE/LICENSE].md

Posted by GitBox <gi...@apache.org>.
radio-rogal edited a comment on pull request #51:
URL: https://github.com/apache/maven-shade-plugin/pull/51#issuecomment-1001168329


   ~~Could you reopen this PR?~~ Not needed, it was merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] radio-rogal commented on pull request #51: [MSHADE-371] Update Shade Apache[Notice/LICENSE] ResourceTransformer to use [NOTICE/LICENSE].md

Posted by GitBox <gi...@apache.org>.
radio-rogal commented on pull request #51:
URL: https://github.com/apache/maven-shade-plugin/pull/51#issuecomment-1001217193


   It's marked as closed not merged. So I have thought that it was declined as there are no tests.
   
   Then I have checked Git history and found these changes are in **master**. I have edited my previous comment :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] asfgit closed pull request #51: [MSHADE-371] Update Shade Apache[Notice/LICENSE] ResourceTransformer to use [NOTICE/LICENSE].md

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #51:
URL: https://github.com/apache/maven-shade-plugin/pull/51


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shade-plugin] slachiewicz commented on pull request #51: [MSHADE-371] Update Shade Apache[Notice/LICENSE] ResourceTransformer to use [NOTICE/LICENSE].md

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #51:
URL: https://github.com/apache/maven-shade-plugin/pull/51#issuecomment-1001178462


   It has been merged to master branch and will be part of next release. Why we should reopen PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org