You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cadonna (via GitHub)" <gi...@apache.org> on 2024/12/16 13:43:30 UTC
[PR] Add warm-up tasks to Streams membership manager [kafka]
cadonna opened a new pull request, #18214:
URL: https://github.com/apache/kafka/pull/18214
This commit adds warm-up tasks assignment to the
Streams membership manager.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add warm-up tasks to Streams membership manager [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on code in PR #18214:
URL: https://github.com/apache/kafka/pull/18214#discussion_r1888407997
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##########
@@ -833,12 +838,20 @@ private CompletableFuture<Void> revokeActiveTasks(final SortedSet<StreamsAssignm
private CompletableFuture<Void> assignTasks(final SortedSet<StreamsAssignmentInterface.TaskId> activeTasksToAssign,
final SortedSet<StreamsAssignmentInterface.TaskId> ownedActiveTasks,
- final SortedSet<StreamsAssignmentInterface.TaskId> standbyTasksToAssign) {
- log.info("Assigning active tasks {} and standby tasks {}",
+ final SortedSet<StreamsAssignmentInterface.TaskId> standbyTasksToAssign,
+ final SortedSet<StreamsAssignmentInterface.TaskId> warmupTasksToAssign) {
+ log.info("Assigning " +
Review Comment:
I think (I am not sure I remember correctly), I added this at `info` level because there is a similar message in the `revokeActiveTasks()`. I will keep it at `info` for now and we can change it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add warm-up tasks to Streams membership manager [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #18214:
URL: https://github.com/apache/kafka/pull/18214#discussion_r1887230884
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##########
@@ -833,12 +838,20 @@ private CompletableFuture<Void> revokeActiveTasks(final SortedSet<StreamsAssignm
private CompletableFuture<Void> assignTasks(final SortedSet<StreamsAssignmentInterface.TaskId> activeTasksToAssign,
final SortedSet<StreamsAssignmentInterface.TaskId> ownedActiveTasks,
- final SortedSet<StreamsAssignmentInterface.TaskId> standbyTasksToAssign) {
- log.info("Assigning active tasks {} and standby tasks {}",
+ final SortedSet<StreamsAssignmentInterface.TaskId> standbyTasksToAssign,
+ final SortedSet<StreamsAssignmentInterface.TaskId> warmupTasksToAssign) {
+ log.info("Assigning " +
Review Comment:
nit: Should this be `info` or `debug` ? I don't remember from previous PRs so maybe info here is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add warm-up tasks to Streams membership manager [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna merged PR #18214:
URL: https://github.com/apache/kafka/pull/18214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org