You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by dlaboss <gi...@git.apache.org> on 2016/04/05 18:54:23 UTC

[GitHub] incubator-quarks-website pull request: [QUARKS-107] Add use of Ran...

GitHub user dlaboss opened a pull request:

    https://github.com/apache/incubator-quarks-website/pull/32

    [QUARKS-107] Add use of Range in recipe

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlaboss/incubator-quarks-website range

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks-website/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: [QUARKS-107] Add use of Ran...

Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on the pull request:

    https://github.com/apache/incubator-quarks-website/pull/32#issuecomment-205893824
  
    @queeniema pls review the changes since you were the recipe's author.  thx!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: [QUARKS-107] Add use of Ran...

Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks-website/pull/32#discussion_r58579856
  
    --- Diff: site/recipes/recipe_value_out_of_range.md ---
    @@ -137,6 +137,36 @@ When the final application is run, the output looks something like the following
     
     Note that the deadband filter outputs a warning message for the very first temperature reading of 79.1°F. When the temperature falls to 76.5°F (which is outside the optimal range), both the simple filter and deadband filter print out a warning message. However, when the temperature returns to normal at 77.5°F, only the deadband filter prints out a message as it is the first value inside the optimal range after a period of being outside it.
     
    +## Range values
    +
    +Filtering against a range of values is such a common analytic activity that the ``quarks.analytics.sensors.Range`` class is provided to assist with that.
    +
    +Using a Range can simplify and clarify your application code and lessen mistakes that may occur when writing expressions to deal with ranges.
    +Though not covered in this recipe, Ranges offer additional conveniences for creating applications with external range specifications and adaptable filters.
    +
    +In the above examples, a single Range can be used in place of the two
    +different expressions for the same logical range:
    --- End diff --
    
    done!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: [QUARKS-107] Add use of Ran...

Posted by queeniema <gi...@git.apache.org>.
Github user queeniema commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks-website/pull/32#discussion_r58578295
  
    --- Diff: site/recipes/recipe_value_out_of_range.md ---
    @@ -137,6 +137,36 @@ When the final application is run, the output looks something like the following
     
     Note that the deadband filter outputs a warning message for the very first temperature reading of 79.1°F. When the temperature falls to 76.5°F (which is outside the optimal range), both the simple filter and deadband filter print out a warning message. However, when the temperature returns to normal at 77.5°F, only the deadband filter prints out a message as it is the first value inside the optimal range after a period of being outside it.
     
    +## Range values
    +
    +Filtering against a range of values is such a common analytic activity that the ``quarks.analytics.sensors.Range`` class is provided to assist with that.
    +
    +Using a Range can simplify and clarify your application code and lessen mistakes that may occur when writing expressions to deal with ranges.
    +Though not covered in this recipe, Ranges offer additional conveniences for creating applications with external range specifications and adaptable filters.
    +
    +In the above examples, a single Range can be used in place of the two
    +different expressions for the same logical range:
    --- End diff --
    
    @dlaboss For consistency, could you combine these two lines into one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: [QUARKS-107] Add use of Ran...

Posted by queeniema <gi...@git.apache.org>.
Github user queeniema commented on the pull request:

    https://github.com/apache/incubator-quarks-website/pull/32#issuecomment-205906038
  
    These additions look great and simplify the code. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks-website pull request: [QUARKS-107] Add use of Ran...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quarks-website/pull/32


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---