You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by rerngvit <gi...@git.apache.org> on 2016/07/22 06:42:04 UTC
[GitHub] zeppelin pull request #1216: [ZEPPELIN-919] Apply new mechanism to Markdown
GitHub user rerngvit opened a pull request:
https://github.com/apache/zeppelin/pull/1216
[ZEPPELIN-919] Apply new mechanism to Markdown
### What is this PR for?
This PR applies the new interpreter registration mechanism to Markdown
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-919
### How should this be tested?
1. apply patch
2. rm -r interpreter/md
3. rm conf/interpreter.json
4. mvn clean package -DskipTests
5. bin/zeppelin-daemon.sh start
6. run some paragraph with markdown
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rerngvit/incubator-zeppelin ZEPPELIN-919
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1216
----
commit dac4fbb4d631596805de185405d293e95a703f7c
Author: Rerngvit Yanggratoke <re...@gmail.com>
Date: 2016-07-21T22:14:14Z
### What is this PR for?
This PR applies the new interpreter registration mechanism to Markdown
### What type of PR is it?
Improvement
### Todos
- Move interpreter registration properties from static block to interpreter-setting.json
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-919
### How should this be tested?
1. apply patch
2. rm -r interpreter/md
3. rm conf/interpreter.json
4. mvn clean package -DskipTests
5. bin/zeppelin-daemon.sh start
6. run some paragraph with markdown
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1216: [ZEPPELIN-919] Apply new mechanism to Markdown
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1216
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1216: [ZEPPELIN-919] Apply new mechanism to Markdown
Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:
https://github.com/apache/zeppelin/pull/1216
@bzz @jongyoul
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1216: [ZEPPELIN-919] Apply new mechanism to Markdown
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1216: [ZEPPELIN-919] Apply new mechanism to Markdown
Posted by rerngvit <gi...@git.apache.org>.
Github user rerngvit commented on the issue:
https://github.com/apache/zeppelin/pull/1216
@prabhjyotsingh Just did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1216: [ZEPPELIN-919] Apply new mechanism to Markdown
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1216
CI green.
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---