You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by benoyantony <gi...@git.apache.org> on 2017/04/28 06:57:25 UTC

[GitHub] zeppelin pull request #2297: [ZEPPELIN-2465] Minor code fixes for the livy p...

GitHub user benoyantony opened a pull request:

    https://github.com/apache/zeppelin/pull/2297

    [ZEPPELIN-2465] Minor code fixes for the livy package

    ### What is this PR for?
    Minor code fixes for the livy package.
    The code fixes include :
    Fixing a typo in a classname - BaseLivyInterprereter to BaseLivyInterpreter
    Removing an unused variable in BaseLivyInterpreter
    Removing unused imports in a few classes
    
    
    ### What type of PR is it?
    Refactoring
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2465
    
    ### How should this be tested?
    No need to test as there is no change in funcionality
    
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benoyantony/zeppelin refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2297
    
----
commit 74016ad7aea693df56e1f661afcd875bf548191b
Author: Benoy Antony <be...@apache.org>
Date:   2017-04-28T06:51:48Z

    ZEPPELIN-2465 Minor code fixes for the livy package

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2297: [ZEPPELIN-2465] Minor code fixes for the livy package

Posted by benoyantony <gi...@git.apache.org>.

Github user benoyantony commented on the issue:

    https://github.com/apache/zeppelin/pull/2297
  
    @zjffdu , could you please review this change ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2297: [ZEPPELIN-2465] Minor code fixes for the livy p...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2297


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2297: [ZEPPELIN-2465] Minor code fixes for the livy package

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2297
  
    Thanks @benoyantony , LGTM, wait for CI pass


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---