You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "lucafabbian (via GitHub)" <gi...@apache.org> on 2024/11/25 14:33:45 UTC

[PR] Fixed imports in custom_datasource.rs example [datafusion]

lucafabbian opened a new pull request, #13561:
URL: https://github.com/apache/datafusion/pull/13561

   Made imports explicit so the "custom datasource" example can be copied/pasted outside the repo.
   
   ## Rationale for this change
   
   This example was referenced in the wiki, but some imports were not friendly for copying/paste. I see no reason to keep them the old way, especially because the file is meant to be a template.
   
   ## What changes are included in this PR?
   
   I have just renamed the imports to make them work outside this repo.
   
   ## Are these changes tested?
   
   Now the example could be compiled without issue :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fixed imports in custom_datasource.rs example [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #13561:
URL: https://github.com/apache/datafusion/pull/13561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org