You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2018/09/25 20:37:03 UTC
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11512
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
CatalogdTableInvalidator detects if a table is in a normal state using
Table.isLoaded() function. This is wrong because if there is an error
during the loading of a table, isLoaded() returns true. This patch
checks if the table is an IncompleteTable instead.
Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
---
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/11512/1
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
CatalogdTableInvalidator detects if a table is in a normal state using
Table.isLoaded() function. This is wrong because if there is an error
during the loading of a table, isLoaded() returns true. This patch
checks if the table is an IncompleteTable instead.
Also fixed a bug in tryInstallGcListener(). A test is added to test the
memory-based invalidation.
Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
---
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M tests/custom_cluster/test_automatic_invalidation.py
2 files changed, 36 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/11512/4
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
CatalogdTableInvalidator detects if a table is in a normal state using
Table.isLoaded() function. This is wrong because if there is an error
during the loading of a table, isLoaded() returns true. This patch
checks if the table is an IncompleteTable instead.
Also fixed a bug in tryInstallGcListener(). A test is added to test the
memory-based invalidation.
Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Reviewed-on: http://gerrit.cloudera.org:8080/11512
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M tests/custom_cluster/test_automatic_invalidation.py
2 files changed, 36 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 6
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11512/2/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java:
http://gerrit.cloudera.org:8080/#/c/11512/2/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@157
PS2, Line 157: NotificationEmitter
any thoughts on how to test this? it seemed to pass manual tests, so wondering what went wrong here and if we can guard against it in the future.
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py
File tests/custom_cluster/test_automatic_invalidation.py:
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@81
PS2, Line 81: doesn't
nit: don't
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@81
PS2, Line 81: an
nit: a
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@82
PS2, Line 82: in the
nit: for
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Sep 2018 00:39:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11512/1/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java:
http://gerrit.cloudera.org:8080/#/c/11512/1/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@228
PS1, Line 228: if (table instanceof IncompleteTable) continue;
any way to test this? I've seen functional.bad_serde used for this purpose-- you'll get an IncompleteTable when you do so. See the CatalogTest.java unit tests for examples.
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Sep 2018 21:13:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/828/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 00:46:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11512/2/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java:
http://gerrit.cloudera.org:8080/#/c/11512/2/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@157
PS2, Line 157: NotificationEmitter
> any thoughts on how to test this? it seemed to pass manual tests, so wonder
added a test using jmap to trigger a GC
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py
File tests/custom_cluster/test_automatic_invalidation.py:
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@81
PS2, Line 81:
> nit: a
Done
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@81
PS2, Line 81:
> nit: don't
Done
http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@82
PS2, Line 82: led to
> nit: for
Done
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Sep 2018 23:58:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/802/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Sep 2018 00:59:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/794/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Sep 2018 21:09:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
CatalogdTableInvalidator detects if a table is in a normal state using
Table.isLoaded() function. This is wrong because if there is an error
during the loading of a table, isLoaded() returns true. This patch
checks if the table is an IncompleteTable instead.
Also fixed a bug in tryInstallGcListener().
Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
---
M fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java
M tests/custom_cluster/test_automatic_invalidation.py
2 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/11512/2
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11512/4/tests/custom_cluster/test_automatic_invalidation.py
File tests/custom_cluster/test_automatic_invalidation.py:
http://gerrit.cloudera.org:8080/#/c/11512/4/tests/custom_cluster/test_automatic_invalidation.py@100
PS4, Line 100: openjdk 1.8.
might be good to verify this for 7 since some tests still run with this afaik.
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 00:14:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 04:21:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3231/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 00:47:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11512/4/tests/custom_cluster/test_automatic_invalidation.py
File tests/custom_cluster/test_automatic_invalidation.py:
http://gerrit.cloudera.org:8080/#/c/11512/4/tests/custom_cluster/test_automatic_invalidation.py@100
PS4, Line 100: openjdk 1.8.
> might be good to verify this for 7 since some tests still run with this afa
Someone checked the source code and it does. https://stackoverflow.com/questions/11390665/can-jmap-histo-trigger-full-garbage-collection#15747911 It's not a documented feature BTW.
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 00:47:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce
Gerrit-Change-Number: 11512
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 00:47:50 +0000
Gerrit-HasComments: No