[jira] [Resolved] (IMPALA-7153) filesystem_client methods expect unusual paths

["Joe McDonnell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-7153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe McDonnell resolved IMPALA-7153.
-----------------------------------
    Fix Version/s: Impala 3.3.0
       Resolution: Fixed

The filesystem methods now take either type of path. This was fixed as part of handling S3Guard:

https://github.com/apache/impala/commit/6b09612e763aace6ec3ec22031e4e960b9a41e3d

> filesystem_client methods expect unusual paths
> ----------------------------------------------
>
>                 Key: IMPALA-7153
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7153
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.0
>            Reporter: Daniel Hecht
>            Priority: Major
>              Labels: ramp-up
>             Fix For: Impala 3.3.0
>
>
> In Impala end to end python tests, most paths are either absolute or fully qualified (i.e. /test-warehouse/db/table or hdfs://namenode:port/test-warehouse/db/table), yet the classes derived from BaseFilesystem tend to expect paths that are absolute but without the leading slash.
> This leads to awkward and error prone testing code. For example, see IMPALA-7099 and {{test_unsupported_text_compression()}} which does e.g.:
> {code}
>     self.filesystem_client.create_file("{0}/fake.lz4".format(lz4_ym_partition_loc)[1:],
>         "some test data")
> {code}
> Not only is this confusing, but it doesn't work when the test is run with FILESYSTEM_PREFIX not empty.
> We should fix the filesystem_client classes to handle absolute and fully qualified paths so that each test doesn't have to worry about this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)