You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/02 08:29:16 UTC
[GitHub] [flink] cun8cun8 opened a new pull request, #20742: [FLINK-29156]Support LISTAGG in the Table API
cun8cun8 opened a new pull request, #20742:
URL: https://github.com/apache/flink/pull/20742
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
dianfu commented on code in PR #20742:
URL: https://github.com/apache/flink/pull/20742#discussion_r984165780
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/table/AggregateITCase.scala:
##########
@@ -259,6 +259,30 @@ class AggregateITCase(mode: StateBackendMode) extends StreamingWithStateTestBase
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ @Test
+ def testListAggWithExpression():Unit = {
Review Comment:
Could we integrate the test into the other test cases, e.g. testGroupAggregateWithExpression to avoid introducing an extra IT case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cun8cun8 commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
cun8cun8 commented on code in PR #20742:
URL: https://github.com/apache/flink/pull/20742#discussion_r962093570
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala:
##########
@@ -62,17 +62,17 @@ class StreamingWithStateTestBase(state: StateBackendMode) extends StreamingTestB
super.before()
// set state backend
baseCheckpointPath = tempFolder.newFolder().getAbsoluteFile
- state match {
- case HEAP_BACKEND =>
- val conf = new Configuration()
- env.setStateBackend(
- new MemoryStateBackend("file://" + baseCheckpointPath, null).configure(conf, classLoader))
- case ROCKSDB_BACKEND =>
- val conf = new Configuration()
- conf.setBoolean(CheckpointingOptions.INCREMENTAL_CHECKPOINTS, true)
- env.setStateBackend(
- new RocksDBStateBackend("file://" + baseCheckpointPath).configure(conf, classLoader))
- }
+// state match {
+// case HEAP_BACKEND =>
+// val conf = new Configuration()
+// env.setStateBackend(
+// new MemoryStateBackend("file://" + baseCheckpointPath, null).configure(conf, classLoader))
+// case ROCKSDB_BACKEND =>
+// val conf = new Configuration()
+// conf.setBoolean(CheckpointingOptions.INCREMENTAL_CHECKPOINTS, true)
+// env.setStateBackend(
+// new RocksDBStateBackend("file://" + baseCheckpointPath).configure(conf, classLoader))
+// }
Review Comment:
Sorry, this is a wrong operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20742:
URL: https://github.com/apache/flink/pull/20742#issuecomment-1235226177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "990afae4c0ff2eb2964d29c8095bacb1ceadb873",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "990afae4c0ff2eb2964d29c8095bacb1ceadb873",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 990afae4c0ff2eb2964d29c8095bacb1ceadb873 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cun8cun8 commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
cun8cun8 commented on code in PR #20742:
URL: https://github.com/apache/flink/pull/20742#discussion_r962093570
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala:
##########
@@ -62,17 +62,17 @@ class StreamingWithStateTestBase(state: StateBackendMode) extends StreamingTestB
super.before()
// set state backend
baseCheckpointPath = tempFolder.newFolder().getAbsoluteFile
- state match {
- case HEAP_BACKEND =>
- val conf = new Configuration()
- env.setStateBackend(
- new MemoryStateBackend("file://" + baseCheckpointPath, null).configure(conf, classLoader))
- case ROCKSDB_BACKEND =>
- val conf = new Configuration()
- conf.setBoolean(CheckpointingOptions.INCREMENTAL_CHECKPOINTS, true)
- env.setStateBackend(
- new RocksDBStateBackend("file://" + baseCheckpointPath).configure(conf, classLoader))
- }
+// state match {
+// case HEAP_BACKEND =>
+// val conf = new Configuration()
+// env.setStateBackend(
+// new MemoryStateBackend("file://" + baseCheckpointPath, null).configure(conf, classLoader))
+// case ROCKSDB_BACKEND =>
+// val conf = new Configuration()
+// conf.setBoolean(CheckpointingOptions.INCREMENTAL_CHECKPOINTS, true)
+// env.setStateBackend(
+// new RocksDBStateBackend("file://" + baseCheckpointPath).configure(conf, classLoader))
+// }
Review Comment:
Sorry, this is a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on code in PR #20742:
URL: https://github.com/apache/flink/pull/20742#discussion_r962354368
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/table/AggregateITCase.scala:
##########
@@ -259,6 +259,30 @@ class AggregateITCase(mode: StateBackendMode) extends StreamingWithStateTestBase
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ @Test
+ def testListAggWithExpression():Unit = {
+ val data = new mutable.MutableList[(Int, String)]
+ data.+=((1, "A"))
+ data.+=((1, "B"))
+ data.+=((2, "B"))
+ data.+=((2, "C"))
+ data.+=((2, "C"))
+
+ val t = failingDataSource(data)
+ .toTable(tEnv, 'a, 'b)
+ .groupBy('a)
+ .select('a, 'b.listAgg("-"), call("list_Agg", col("b"), "~"))
Review Comment:
It's better to have SQL functions in uppercase like it's done for others
why does it have underscore in the middle? In SQL Standard it does not have underscore as well as in jira issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on code in PR #20742:
URL: https://github.com/apache/flink/pull/20742#discussion_r961734554
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/StreamingWithStateTestBase.scala:
##########
@@ -62,17 +62,17 @@ class StreamingWithStateTestBase(state: StateBackendMode) extends StreamingTestB
super.before()
// set state backend
baseCheckpointPath = tempFolder.newFolder().getAbsoluteFile
- state match {
- case HEAP_BACKEND =>
- val conf = new Configuration()
- env.setStateBackend(
- new MemoryStateBackend("file://" + baseCheckpointPath, null).configure(conf, classLoader))
- case ROCKSDB_BACKEND =>
- val conf = new Configuration()
- conf.setBoolean(CheckpointingOptions.INCREMENTAL_CHECKPOINTS, true)
- env.setStateBackend(
- new RocksDBStateBackend("file://" + baseCheckpointPath).configure(conf, classLoader))
- }
+// state match {
+// case HEAP_BACKEND =>
+// val conf = new Configuration()
+// env.setStateBackend(
+// new MemoryStateBackend("file://" + baseCheckpointPath, null).configure(conf, classLoader))
+// case ROCKSDB_BACKEND =>
+// val conf = new Configuration()
+// conf.setBoolean(CheckpointingOptions.INCREMENTAL_CHECKPOINTS, true)
+// env.setStateBackend(
+// new RocksDBStateBackend("file://" + baseCheckpointPath).configure(conf, classLoader))
+// }
Review Comment:
Could you please clarify why this is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on a diff in pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on code in PR #20742:
URL: https://github.com/apache/flink/pull/20742#discussion_r962354424
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/SqlAggFunctionVisitor.java:
##########
@@ -70,6 +70,8 @@ public class SqlAggFunctionVisitor extends ExpressionDefaultVisitor<SqlAggFuncti
BuiltInFunctionDefinitions.FIRST_VALUE, FlinkSqlOperatorTable.FIRST_VALUE);
AGG_DEF_SQL_OPERATOR_MAPPING.put(
BuiltInFunctionDefinitions.LAST_VALUE, FlinkSqlOperatorTable.LAST_VALUE);
+ AGG_DEF_SQL_OPERATOR_MAPPING.put(
+ BuiltInFunctionDefinitions.LIST_AGG, FlinkSqlOperatorTable.LISTAGG);
Review Comment:
Why does it have underscore in the middle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
URL: https://github.com/apache/flink/pull/20742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #20742: [FLINK-29156]Support LISTAGG in the Table API
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #20742:
URL: https://github.com/apache/flink/pull/20742#issuecomment-1235562818
Please make sure that you use and fill in the PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org