You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2024/10/18 08:06:22 UTC
[PR] Always use logical date in DAG run header [airflow]
uranusjr opened a new pull request, #43148:
URL: https://github.com/apache/airflow/pull/43148
In #38365, it was mentioned the label really should use logical date, not data interval end. This comment was however not addressed at all before the PR was merged.
While using `dataIntervalEnd` fixes _some_ of the runs, it actually makes the display wrong for others. The run ID is generated from logical date, which _may_ be data interval start or end, or another value altogether depending on how the DAG is configured (specifically which timetable is used) and how the run is triggered. Using either `dataIntervalStart` or `dataIntervalEnd` is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Always use logical date in DAG run header [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on code in PR #43148:
URL: https://github.com/apache/airflow/pull/43148#discussion_r1817390090
##########
airflow/www/static/js/utils/index.ts:
##########
@@ -169,7 +169,7 @@ interface RunLabelProps {
const getDagRunLabel = ({
dagRun,
- ordering = ["dataIntervalStart", "executionDate"],
+ ordering = ["executionDate"],
}: RunLabelProps) => dagRun[ordering[0]] ?? dagRun[ordering[1]];
Review Comment:
I raise a PR that should solve it
https://github.com/apache/airflow/pull/43388/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Always use logical date in DAG run header [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #43148: Always use logical date in DAG run header
URL: https://github.com/apache/airflow/pull/43148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Always use logical date in DAG run header [airflow]
Posted by "matschaffer-roblox (via GitHub)" <gi...@apache.org>.
matschaffer-roblox commented on code in PR #43148:
URL: https://github.com/apache/airflow/pull/43148#discussion_r1814039228
##########
airflow/www/static/js/utils/index.ts:
##########
@@ -169,7 +169,7 @@ interface RunLabelProps {
const getDagRunLabel = ({
dagRun,
- ordering = ["dataIntervalStart", "executionDate"],
+ ordering = ["executionDate"],
}: RunLabelProps) => dagRun[ordering[0]] ?? dagRun[ordering[1]];
Review Comment:
I guess `dagRun` should always have an `executionDate` but seems like you have an extra risk of `undefined` here since you removed `ordering[1]` from the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Always use logical date in DAG run header [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #43148:
URL: https://github.com/apache/airflow/pull/43148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org