You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "I3eka (via GitHub)" <gi...@apache.org> on 2026/09/23 03:57:34 UTC

[PR] fix(ai): remember the profile of each conversation [superset]

I3eka opened a new pull request, #44555:
URL: https://github.com/apache/superset/pull/44555

### SUMMARY

Keep the selected AI profile with its conversation instead of silently replacing it with the browser's global preference or the default profile.

This independently reproduces the [human review finding in #43133](https://github.com/apache/superset/pull/43133#discussion_r3995799995) and the [Copilot finding in #43237](https://github.com/apache/superset/pull/43237#discussion_r4002625715).

- Resolve an omitted, null or empty key from the owned thread through the existing gated `ProfileRegistry`, before storing messages or dispatching work. Remember the resolved key on both the conversation and the run's assistant message.
- Keep profile selections per tab. Reopening restores the server's profile, and the browser sends `agent_key` only for an explicit selection, including `default`. A later selection does not retarget an accepted run or get erased by its completion refresh.
- Retain existing permitted-profile fallback behavior. If no profile is permitted/configured, reject before creating message rows.

**Stack/dependencies:** this is a focused follow-up to the unmerged AI base #42805, not a standalone addition of Native AI. The shared `native-ai-base-compatibility` branch includes Apache master `9612437a9c` and the separately committed migration reconciliation. The profile-only delta is [these eleven files above the shared base](https://github.com/I3eka/superset/compare/dab76d93fc219d577aca4c316fd5b29588bd64ad...native-ai-thread-profile). The main GitHub diff still includes the unmerged prerequisite.

This does **not** fix run idempotency, queue recovery, cancellation, page-context framing, model pinning, or authoring timeouts. It does not resolve the corresponding parent review threads or the SIP hold. @sadpandajoe, the regression covers both stored API profiles and reopened UI tabs from your finding.

### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual redesign; the same selector keeps the correct state.

| Action | Before | After |
| --- | --- | --- |
| Post without a key to an `analyst` conversation | Default profile | Stored permitted profile |
| Explicitly select `default` | Browser omits the key | Explicit reset reaches the API |
| Reopen or switch conversations | Global browser selection | Each conversation's stored profile |

### TESTING INSTRUCTIONS

- **726 backend checks pass:** the entire AI unit suite plus the actual Alembic single-head test. Thirty profile cases cover creation through the HTTP API, ownership, omitted/null/empty/explicit keys, removed/denied profiles, no available profile, remembered selection, and immutable per-run snapshots in both inline and worker configurations.
- **152 frontend tests / twelve suites pass:** all AI and shared-chat tests. Regressions cover reopening, switching tabs, unsent choices during a running turn, resolved fallback, new conversations, and omitted versus explicit keys on the wire.
- All applicable pre-commit hooks over the complete PR delta pass, including mypy and frontend type checking.
- Independent red controls: the unmodified backend fails the profile cases after isolating event logging; restoring only the old request-key omission fails the explicit-default wire test while omitted/analyst controls pass.
- API tests use isolated SQLite and the real routes/DAO/registry, but stub route authentication/current-user identity, logging and execution delivery. Frontend transport is mocked. No claim of real broker delivery, an external LLM run or live-browser deployment validation.
- The new master migration conflict was reproduced with the real single-head test before the shared no-op join. The resulting graph has one head. A complete database upgrade/downgrade cycle is **not** claimed.

Manual checks with `AI_ASSISTANT` enabled:

1. Create an `analyst` conversation, submit a message without `agent_key`, and verify the returned thread and stored assistant extra both identify `analyst`.
2. Explicitly choose the default profile, send another message, reopen the conversation, and confirm the selector and stored profile remain default.
3. Switch between two conversations with different profiles. While one runs, choose a profile for its next turn and switch away; completion must not change the other tab or discard that unsent choice.

No deployment, live database migration, configuration change or warehouse query was performed. Remote CI is separate from the local results above.

### ADDITIONAL INFORMATION

- [x] Has associated issue: the two inline review findings linked above
- [x] Required feature flags: `AI_ASSISTANT` from #42805
- [x] Changes UI: profile selection state only
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)): inherited AI schema plus shared no-op joins; no profile-specific migration
- [x] Migration is atomic, supports rollback & is backwards-compatible: the new shared join has no schema/data operations and preserves published revisions
- [ ] Confirm DB migration upgrade and downgrade tested
- [x] Runtime estimates and downtime expectations provided: the new join performs only Alembic revision bookkeeping, with no data scan or schema operation; no deployment performed
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6461092935

### ⚠️ Possible DB migration conflict

@I3eka the base branch `master` picked up a new database migration under `superset/migrations/` after this PR was opened, and this PR adds or modifies migration files too. Alembic migrations form a single linear chain, so if both branch off the same parent revision, merging this PR as-is could leave the migration history with two heads instead of one, which makes `superset db upgrade` fail with `Multiple head revisions are present`.

To check and, if needed, fix this:

1. Rebase this branch onto the latest `master`.
2. Run `superset db heads`. If it lists more than one revision, you have a conflict.
3. In your new migration's script, update `down_revision` (and the `Revises` comment) to point at the other head instead, so the chain has a single head again.

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6307957797

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6070753237

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.

netlify[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-5788754019

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 1b81ef01b365ae18c8a9a803a22bbcc626716f5d |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ab34e2e68ed7d0009f45605 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44555--superset-docs-preview.netlify.app](https://deploy-preview-44555--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ0NTU1LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.ptMBjQh672jlDX80itNqBa1_gCx5BiaMKqnGVL8rlBE)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLCoAgEADQu8w6QSrtc4OOMTYjCqYiEkR092b3Fu-F2spVO-wAA7iG-QzijD3erDCqHhojKVk-JpZDXFN5DpJl0U0zj2xXpoW01pufjdUGvh8) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-44555--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.

bito-code-review[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-5788728355

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-5941624440

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "I3eka (via GitHub)" <gi...@apache.org>.

I3eka commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6435545396

Reviewed the current discussion and the focused implementation, and merged Apache master `037abb7d0b433c1274ab55f95e5613310f132462` without rewriting the branch. Published head: `d5f8afe08846e62664a2f93005827a4e2193e051`. There are no inline review threads or outstanding substantive reviewer findings on this PR in this audit. I also checked the repeated automated migration notices (latest: https://github.com/apache/superset/pull/44555#issuecomment-6307957797); the actual revision-head test passes. The notice alone is not evidence of a broken migration graph.

- 727 tests passed: the full AI unit suite and the single-migration-head check.
- 114 AI frontend tests passed.
- All applicable pre-commit hooks passed for the 117 files in this PR delta.
- The translation template matches a fresh extraction from the exact committed tree.

Real isolated route/DAO/registry tests control authentication and delivery; UI transport is mocked. This does not establish live provider, broker or deployment behavior.

Updated the description to match this head and its validation. This stays **Draft / ON HOLD** behind #42805 and SIP #42806. No deployment, live database migration or external provider call was performed; GitHub CI is separate from these local checks.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6022169231

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6281395231

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-5953104888

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-5788763421

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44555?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 66.30%. Comparing base ([`9612437`](https://app.codecov.io/gh/apache/superset/commit/9612437a9c8de2cad3f5aebfa728ec0663a9e3b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1b81ef0`](https://app.codecov.io/gh/apache/superset/commit/1b81ef01b365ae18c8a9a803a22bbcc626716f5d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #44555      +/-   ##
   ==========================================
   + Coverage   66.22%   66.30%   +0.08%     
   ==========================================
     Files        2949     2954       +5     
     Lines      177381   178009     +628     
     Branches    41107    41107              
   ==========================================
   + Hits       117462   118035     +573     
   - Misses      57415    57470      +55     
     Partials     2504     2504              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/44555/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [superset-extensions-cli](https://app.codecov.io/gh/apache/superset/pull/44555/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.24% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44555?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6455915530

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "I3eka (via GitHub)" <gi...@apache.org>.

I3eka commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-5790047578

   The first CI pass caught two genuine shared-base issues: a stale messages.pot (116 new msgids and one stale entry) and a setupApp.ts formatting difference under the locked oxfmt 0.68.0. Both reproduced locally and are fixed in separate shared-base commits, inherited here by 01dc174c40. A fresh Babel extraction matches the template; existing message flags and locale translations are unchanged.
   
   The updated head passes 733 backend checks, 152 frontend tests, and all applicable pre-commit hooks over the complete PR delta, using oxfmt 0.68.0. Remote CI is still separate/pending; this does not remove the prerequisite/SIP hold or resolve the other lifecycle findings. No service deployment or database migration was performed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6102864506

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(ai): remember the profile of each conversation [superset]

Posted by "github-actions[bot] (via GitHub) via notifications" <no...@superset.apache.org>.

github-actions[bot] commented on PR #44555:
URL: https://github.com/apache/superset/pull/44555#issuecomment-6589613339

### ⚠️ Possible DB migration conflict

To check and, if needed, fix this:

See [Merging DB Migrations](https://superset.apache.org/docs/contributing/development#merging-db-migrations) in the contributing guide for a worked example.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org