You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/10/16 09:53:34 UTC
[GitHub] [kibble] turbaszek opened a new pull request #58: Apply pre-commit checks to all files and make CI green
turbaszek opened a new pull request #58:
URL: https://github.com/apache/kibble/pull/58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] Humbedooh merged pull request #58: Apply pre-commit checks to all files and make CI green
Posted by GitBox <gi...@apache.org>.
Humbedooh merged pull request #58:
URL: https://github.com/apache/kibble/pull/58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #58: Apply pre-commit checks to all files and make CI green
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #58:
URL: https://github.com/apache/kibble/pull/58#issuecomment-709962473
> Can you confirm that there is no functional change?
Yes, I only applied auto changes. And using them for last year I'm sure there's no functional change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on pull request #58: Apply pre-commit checks to all files and make CI green
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #58:
URL: https://github.com/apache/kibble/pull/58#issuecomment-709959522
@sharanf @Humbedooh - there's a lot of changes but they were automatically done by pre-commit (removing ending whitespaces and adding missing new lines at the end of files)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] Humbedooh commented on pull request #58: Apply pre-commit checks to all files and make CI green
Posted by GitBox <gi...@apache.org>.
Humbedooh commented on pull request #58:
URL: https://github.com/apache/kibble/pull/58#issuecomment-709961131
I've only checked about 10% of the changes, but yeah looks like generic linting.
Can you confirm that there is no functional change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org