[GitHub] [hive] okumin commented on a change in pull request #1636: HIVE-24313: Optimise stats collection for file sizes on cloud storage

[GitBox <gi...@apache.org>]

okumin commented on a change in pull request #1636:
URL: https://github.com/apache/hive/pull/1636#discussion_r572272405



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
##########
@@ -316,12 +319,11 @@ private static Statistics collectStatistics(HiveConf conf, PrunedPartitionList p
 
       basicStatsFactory.addEnhancer(new BasicStats.RowNumEstimator(estimateRowSizeFromSchema(conf, schema)));
 
-      List<BasicStats> partStats = new ArrayList<>();
+      List<BasicStats> partStats =
+          partList.getNotDeniedPartns().parallelStream().

Review comment:
       The point is `basicStatsFactory.build(Partish.buildFor(table, p))` can block the common pool shared with a whole JVM since it executes blocking-IO?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org