You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/07 19:06:22 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4545: Add tests for coercion of timestamps to strings
alamb opened a new pull request, #4545:
URL: https://github.com/apache/arrow-datafusion/pull/4545
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/4311
# Rationale for this change
Add end to end SQL test coverage for the feature added by @andre-cc-natzka in https://github.com/apache/arrow-datafusion/pull/4312
# What changes are included in this PR?
`timestamp.slt` test
# Are these changes tested?
It is entirely tests
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4545: Add tests for coercion of timestamps to strings
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4545:
URL: https://github.com/apache/arrow-datafusion/pull/4545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4545: Add tests for coercion of timestamps to strings
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on code in PR #4545:
URL: https://github.com/apache/arrow-datafusion/pull/4545#discussion_r1042852571
##########
datafusion/core/tests/sqllogictests/test_files/timestamps.slt:
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+##########
+## DDL Tests
Review Comment:
is this a test for DDL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4545: Add tests for coercion of timestamps to strings
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4545:
URL: https://github.com/apache/arrow-datafusion/pull/4545#discussion_r1043288983
##########
datafusion/core/tests/sqllogictests/test_files/timestamps.slt:
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+
+# http://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+##########
+## DDL Tests
Review Comment:
No, that was copy/paste mistake. 🤦
```suggestion
## Timestamp Handling Tests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org