You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/09/21 19:18:34 UTC
Review Request 68801: Fixed flaky test
`SlaveAuthenticationRetryBackoff`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68801/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann.
Repository: mesos
Description
-------
This patch dispatches `unmocked_authenticate()` call to the
slave actor instead of invoking it directly in the test
thread to avoid race conditions.
Diffs
-----
src/tests/authentication_tests.cpp 19738101e357e0c7a6ce891df2dcaeffa9b2029f
Diff: https://reviews.apache.org/r/68801/diff/1/
Testing
-------
make check
ran `SlaveAuthenticationRetryBackoff` continuously without failure.
Thanks,
Meng Zhu
Re: Review Request 68801: Fixed flaky test
`SlaveAuthenticationRetryBackoff`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68801/#review208883
-----------------------------------------------------------
PASS: Mesos patch 68801 was successfully built and tested.
Reviews applied: `['68801']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2370/mesos-review-68801
- Mesos Reviewbot Windows
On Sept. 21, 2018, 7:18 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68801/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 7:18 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch dispatches `unmocked_authenticate()` call to the
> slave actor instead of invoking it directly in the test
> thread to avoid race conditions.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 19738101e357e0c7a6ce891df2dcaeffa9b2029f
>
>
> Diff: https://reviews.apache.org/r/68801/diff/1/
>
>
> Testing
> -------
>
> make check
> ran `SlaveAuthenticationRetryBackoff` continuously without failure.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68801: Fixed flaky test
`SlaveAuthenticationRetryBackoff`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68801/#review208889
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Sept. 21, 2018, 7:18 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68801/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 7:18 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch dispatches `unmocked_authenticate()` call to the
> slave actor instead of invoking it directly in the test
> thread to avoid race conditions.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 19738101e357e0c7a6ce891df2dcaeffa9b2029f
>
>
> Diff: https://reviews.apache.org/r/68801/diff/1/
>
>
> Testing
> -------
>
> make check
> ran `SlaveAuthenticationRetryBackoff` continuously without failure.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68801: Fixed flaky test
`SlaveAuthenticationRetryBackoff`.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68801/#review208878
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Sept. 21, 2018, 12:18 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68801/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 12:18 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch dispatches `unmocked_authenticate()` call to the
> slave actor instead of invoking it directly in the test
> thread to avoid race conditions.
>
>
> Diffs
> -----
>
> src/tests/authentication_tests.cpp 19738101e357e0c7a6ce891df2dcaeffa9b2029f
>
>
> Diff: https://reviews.apache.org/r/68801/diff/1/
>
>
> Testing
> -------
>
> make check
> ran `SlaveAuthenticationRetryBackoff` continuously without failure.
>
>
> Thanks,
>
> Meng Zhu
>
>