You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wusamzong (via GitHub)" <gi...@apache.org> on 2023/06/21 11:29:43 UTC
[GitHub] [yunikorn-core] wusamzong opened a new pull request, #578: [Yunikorn-1819] Update yaml dependency
wusamzong opened a new pull request, #578:
URL: https://github.com/apache/yunikorn-core/pull/578
### What is this PR for?
update the yaml dependency to yaml.v3
### What type of PR is it?
* [x] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1819/
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #578: [Yunikorn-1819] Update yaml dependency
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #578: [Yunikorn-1819] Update yaml dependency
URL: https://github.com/apache/yunikorn-core/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #578: [Yunikorn-1819] Update yaml dependency
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #578:
URL: https://github.com/apache/yunikorn-core/pull/578#discussion_r1238580613
##########
pkg/common/configs/config.go:
##########
@@ -180,6 +181,12 @@ func ParseAndValidateConfig(content []byte) (*SchedulerConfig, error) {
return conf, nil
}
+func UnmarshalStrict(data []byte, v interface{}) error {
Review Comment:
no need to export this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #578: [Yunikorn-1819] Update yaml dependency
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #578:
URL: https://github.com/apache/yunikorn-core/pull/578#issuecomment-1602699487
PR needs a rebase due to go.mod changes since opening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #578: [Yunikorn-1819] Update yaml dependency
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #578:
URL: https://github.com/apache/yunikorn-core/pull/578#issuecomment-1603651900
Can you please check? Build states we need a `go mod tidy` to be run to clean up.
Code changes look good we can commit when the build passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #578: [Yunikorn-1819] Update yaml dependency
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #578:
URL: https://github.com/apache/yunikorn-core/pull/578#issuecomment-1601565231
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#578](https://app.codecov.io/gh/apache/yunikorn-core/pull/578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d25b86b) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/a6a90bb0408a3004592f06d8a79335ac326dcfe4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a6a90bb) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
+ Coverage 75.45% 75.59% +0.13%
==========================================
Files 73 74 +1
Lines 12057 12141 +84
==========================================
+ Hits 9098 9178 +80
- Misses 2638 2642 +4
Partials 321 321
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/handlers.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `80.26% <ø> (+0.46%)` | :arrow_up: |
| [pkg/common/configs/config.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZy5nbw==) | `100.00% <100.00%> (ø)` | |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/578/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org