You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-dev@hadoop.apache.org by Jane Chen <Ja...@marklogic.com> on 2012/01/17 22:34:40 UTC
PATCH APPLICATION FAILED on trunk.
I created and submitted a patch on branch 1. Apparently the patch was attempted to be applied on trunk and failed. What do I need to do to make the patch applied on branch 1?
Thanks,
Jane
-----Original Message-----
From: Hadoop QA (Commented) (JIRA) [mailto:jira@apache.org]
Sent: Tuesday, January 17, 2012 11:26 AM
To: Jane Chen
Subject: [jira] [Commented] (MAPREDUCE-3377) Compatibility issue with 0.20.203.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187914#comment-13187914 ]
Hadoop QA commented on MAPREDUCE-3377:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510875/mapreduce-3377-branch-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1618//console
This message is automatically generated.
> Compatibility issue with 0.20.203.
> ----------------------------------
>
> Key: MAPREDUCE-3377
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3377
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.203.0, 1.0.0
> Environment: 0.20.203.0 standalone JDK 1.6 Linux
> Reporter: Jane Chen
> Assignee: Jane Chen
> Fix For: 1.1.0
>
> Attachments: mapreduce-3377-branch-1.patch, mapreduce-3377.patch, mapreduce-3377.patch
>
>
> I have an OutputFormat which implements Configurable. I set new config entries to a job configuration during checkOutputSpec() so that the tasks will get the config entries through the job configuration. This works fine in 0.20.2, but stopped working starting from 0.20.203. With 0.20.203, my OutputFormat still has the configuration set, but the copy a task gets does not have the new entries that are set as part of checkOutputSpec().
> I believe that the problem is with JobClient. The job configuration needs to wait till checkOutputSpec() is returned before being cloned and submitted.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
RE: PATCH APPLICATION FAILED on trunk.
Posted by Jane Chen <Ja...@marklogic.com>.
Thanks to everyone who replied to my question or commented on the bug. Here's a summary in response to your suggestions/questions:
- I ran ant test on branch-1 and made sure no new diff was introduced. The before and after stdout and stderr files are attached to the bug. I didn't find test-patch on branch-1.
- The issue doesn't exist on trunk. The added unit test passes without any code change. A patch with the unit test only is attached.
Now what?
Jane
-----Original Message-----
From: Arun C Murthy [mailto:acm@hortonworks.com]
Sent: Tuesday, January 17, 2012 1:51 PM
To: mapreduce-dev@hadoop.apache.org
Subject: Re: PATCH APPLICATION FAILED on trunk.
Unfortunately we don't have the necessary infrastructure to run against any branch other than trunk.
I've responded on the jira. Thanks for the patch!
On Jan 17, 2012, at 1:34 PM, Jane Chen wrote:
> I created and submitted a patch on branch 1. Apparently the patch was attempted to be applied on trunk and failed. What do I need to do to make the patch applied on branch 1?
>
> Thanks,
> Jane
>
> -----Original Message-----
> From: Hadoop QA (Commented) (JIRA) [mailto:jira@apache.org]
> Sent: Tuesday, January 17, 2012 11:26 AM
> To: Jane Chen
> Subject: [jira] [Commented] (MAPREDUCE-3377) Compatibility issue with 0.20.203.
>
>
> [ https://issues.apache.org/jira/browse/MAPREDUCE-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187914#comment-13187914 ]
>
> Hadoop QA commented on MAPREDUCE-3377:
> --------------------------------------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12510875/mapreduce-3377-branch-1.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 3 new or modified tests.
>
> -1 patch. The patch command could not apply the patch.
>
> Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1618//console
>
> This message is automatically generated.
>
>> Compatibility issue with 0.20.203.
>> ----------------------------------
>>
>> Key: MAPREDUCE-3377
>> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3377
>> Project: Hadoop Map/Reduce
>> Issue Type: Bug
>> Affects Versions: 0.20.203.0, 1.0.0
>> Environment: 0.20.203.0 standalone JDK 1.6 Linux
>> Reporter: Jane Chen
>> Assignee: Jane Chen
>> Fix For: 1.1.0
>>
>> Attachments: mapreduce-3377-branch-1.patch, mapreduce-3377.patch, mapreduce-3377.patch
>>
>>
>> I have an OutputFormat which implements Configurable. I set new config entries to a job configuration during checkOutputSpec() so that the tasks will get the config entries through the job configuration. This works fine in 0.20.2, but stopped working starting from 0.20.203. With 0.20.203, my OutputFormat still has the configuration set, but the copy a task gets does not have the new entries that are set as part of checkOutputSpec().
>> I believe that the problem is with JobClient. The job configuration needs to wait till checkOutputSpec() is returned before being cloned and submitted.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
Re: PATCH APPLICATION FAILED on trunk.
Posted by Arun C Murthy <ac...@hortonworks.com>.
Unfortunately we don't have the necessary infrastructure to run against any branch other than trunk.
I've responded on the jira. Thanks for the patch!
On Jan 17, 2012, at 1:34 PM, Jane Chen wrote:
> I created and submitted a patch on branch 1. Apparently the patch was attempted to be applied on trunk and failed. What do I need to do to make the patch applied on branch 1?
>
> Thanks,
> Jane
>
> -----Original Message-----
> From: Hadoop QA (Commented) (JIRA) [mailto:jira@apache.org]
> Sent: Tuesday, January 17, 2012 11:26 AM
> To: Jane Chen
> Subject: [jira] [Commented] (MAPREDUCE-3377) Compatibility issue with 0.20.203.
>
>
> [ https://issues.apache.org/jira/browse/MAPREDUCE-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187914#comment-13187914 ]
>
> Hadoop QA commented on MAPREDUCE-3377:
> --------------------------------------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12510875/mapreduce-3377-branch-1.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 3 new or modified tests.
>
> -1 patch. The patch command could not apply the patch.
>
> Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1618//console
>
> This message is automatically generated.
>
>> Compatibility issue with 0.20.203.
>> ----------------------------------
>>
>> Key: MAPREDUCE-3377
>> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3377
>> Project: Hadoop Map/Reduce
>> Issue Type: Bug
>> Affects Versions: 0.20.203.0, 1.0.0
>> Environment: 0.20.203.0 standalone JDK 1.6 Linux
>> Reporter: Jane Chen
>> Assignee: Jane Chen
>> Fix For: 1.1.0
>>
>> Attachments: mapreduce-3377-branch-1.patch, mapreduce-3377.patch, mapreduce-3377.patch
>>
>>
>> I have an OutputFormat which implements Configurable. I set new config entries to a job configuration during checkOutputSpec() so that the tasks will get the config entries through the job configuration. This works fine in 0.20.2, but stopped working starting from 0.20.203. With 0.20.203, my OutputFormat still has the configuration set, but the copy a task gets does not have the new entries that are set as part of checkOutputSpec().
>> I believe that the problem is with JobClient. The job configuration needs to wait till checkOutputSpec() is returned before being cloned and submitted.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
Re: PATCH APPLICATION FAILED on trunk.
Posted by Ted Yu <yu...@gmail.com>.
Jane:
Is your patch applicable on TRUNK ?
If so, why not prepare a patch for TRUNK ?
Hadoop QA always runs patch against TRUNK.
Cheers
On Tue, Jan 17, 2012 at 1:34 PM, Jane Chen <Ja...@marklogic.com> wrote:
> I created and submitted a patch on branch 1. Apparently the patch was
> attempted to be applied on trunk and failed. What do I need to do to make
> the patch applied on branch 1?
>
> Thanks,
> Jane
>
> -----Original Message-----
> From: Hadoop QA (Commented) (JIRA) [mailto:jira@apache.org]
> Sent: Tuesday, January 17, 2012 11:26 AM
> To: Jane Chen
> Subject: [jira] [Commented] (MAPREDUCE-3377) Compatibility issue with
> 0.20.203.
>
>
> [
> https://issues.apache.org/jira/browse/MAPREDUCE-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187914#comment-13187914]
>
> Hadoop QA commented on MAPREDUCE-3377:
> --------------------------------------
>
> -1 overall. Here are the results of testing the latest attachment
>
> http://issues.apache.org/jira/secure/attachment/12510875/mapreduce-3377-branch-1.patch
> against trunk revision .
>
> +1 @author. The patch does not contain any @author tags.
>
> +1 tests included. The patch appears to include 3 new or modified
> tests.
>
> -1 patch. The patch command could not apply the patch.
>
> Console output:
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1618//console
>
> This message is automatically generated.
>
> > Compatibility issue with 0.20.203.
> > ----------------------------------
> >
> > Key: MAPREDUCE-3377
> > URL:
> https://issues.apache.org/jira/browse/MAPREDUCE-3377
> > Project: Hadoop Map/Reduce
> > Issue Type: Bug
> > Affects Versions: 0.20.203.0, 1.0.0
> > Environment: 0.20.203.0 standalone JDK 1.6 Linux
> > Reporter: Jane Chen
> > Assignee: Jane Chen
> > Fix For: 1.1.0
> >
> > Attachments: mapreduce-3377-branch-1.patch,
> mapreduce-3377.patch, mapreduce-3377.patch
> >
> >
> > I have an OutputFormat which implements Configurable. I set new config
> entries to a job configuration during checkOutputSpec() so that the tasks
> will get the config entries through the job configuration. This works fine
> in 0.20.2, but stopped working starting from 0.20.203. With 0.20.203, my
> OutputFormat still has the configuration set, but the copy a task gets does
> not have the new entries that are set as part of checkOutputSpec().
> > I believe that the problem is with JobClient. The job configuration
> needs to wait till checkOutputSpec() is returned before being cloned and
> submitted.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>