[jira] [Commented] (YARN-4855) Should check if node exists when replace nodelabels

["Naganarasimha G R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224216#comment-15224216 ] 

Naganarasimha G R commented on YARN-4855:
-----------------------------------------

[~Tao Jie], This would be a incompatible change and agree it would have been better in the way you had mentioned but anyway it has been done to ease the load of the admin to cross verify if the node is up or down,  so i do not think this can be taken up now without breaking compatability. Thoughts?
cc / [~wangda]

> Should check if node exists when replace nodelabels
> ---------------------------------------------------
>
>                 Key: YARN-4855
>                 URL: https://issues.apache.org/jira/browse/YARN-4855
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Tao Jie
>            Priority: Minor
>
> Today when we add nodelabels to nodes, it would succeed even if nodes are not existing NodeManger in cluster without any message.
> It could be like this:
> When we use *yarn rmadmin -replaceLabelsOnNode "node1=label1"*, it would be denied if node does not exist.
> When we use *yarn rmadmin -replaceLabelsOnNode -force "node1=label1"* would add nodelabels no matter whether node exists



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)