You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/16 06:53:58 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #3967: Adding
novnc
davidjumani opened a new pull request #3967: Adding novnc
URL: https://github.com/apache/cloudstack/pull/3967
## Description
This feature provides novnc console for virtual machines.
It is developed based on noVNC 1.1.0
It includes changes in cloudstack :
(1) add a new websocket proxy to interact with the noVNC console
(2) a ConsoleProxyClient to read / write data from the vm vnc to the websocket.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Works on kvm / ubuntu
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609757971
@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-613954977
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-604394662
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609770954
Packaging result: ✔centos7 ✔debian. JID-1129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-613404368
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-605864160
Packaging result: ✔centos7 ✔debian. JID-1104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609782902
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608304119
@blueorangutan help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-605847998
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-613378158
Verified with multi keyboard layouts! Have to configure the appropriate keyboard layout in the guest VM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3967: noVNC
console integration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306642
@vladimirpetrov I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov']
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-607807783
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-604394512
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-599450289
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306745
@vladimirpetrov I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov']
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306412
@blueorangutan help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609112245
<b>Trillian test result (tid-1353)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 141082 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3967-t1353-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 42 look OK, 41 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 0.69 | test_accounts.py
test_forceDeleteDomain | `Failure` | 0.69 | test_accounts.py
test_forceDeleteDomain | `Error` | 2.84 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 4.90 | test_accounts.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
test_01_create_iso_with_checksum_sha1 | `Error` | 65.76 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 65.64 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 65.36 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 65.36 | test_iso.py
test_01_create_iso | `Failure` | 1518.55 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3068.14 | test_iso.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1515.69 | test_domain_service_offerings.py
test_01_add_delete_kubernetes_supported_version | `Error` | 156.01 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
test_list_clusters_metrics | `Error` | 1512.71 | test_metrics_api.py
test_list_vms_metrics | `Error` | 0.13 | test_metrics_api.py
test_nic_secondaryip_add_remove | `Error` | 1515.61 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
test_delete_account | `Error` | 1515.34 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 0.05 | test_network.py
test_deploy_vm_l2network | `Error` | 0.06 | test_network.py
test_l2network_restart | `Error` | 1.14 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.38 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 0.88 | test_network.py
test_reboot_router | `Error` | 0.04 | test_network.py
test_releaseIP | `Error` | 0.36 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.40 | test_network.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1518.77 | test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.09 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_02_create_template_with_checksum_sha1 | `Error` | 5.12 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 5.13 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 5.11 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 5.12 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_volume_usage | `Failure` | 787.54 | test_usage.py
test_13_attachAndDetach_iso | `Failure` | 1511.49 | test_vm_life_cycle.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.89 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-610095506
<b>Trillian test result (tid-1369)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36627 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3967-t1369-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-604406930
Packaging result: ✔centos7 ✔debian. JID-1094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609783747
@vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306642
@vladimirpetrov I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov']
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-599401966
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1053
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-613955573
@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306379
@blueorangutan help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-600491829
@davidjumani cooooool.
I am currently busy on some other stuff. I will look at it when I am free.
@rhtyd has some ideas. maybe he can help you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-613967547
Packaging result: ✔centos7 ✔debian. JID-1168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-607814334
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-600447706
@ustcweizhou I've created this to use a java websocket proxy which supports client metrics reporting. Could you provide your comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-607813718
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
davidjumani commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-601535108
@rhtyd It's all good from my end, any comments ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3967:
noVNC console integration
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r398866057
##########
File path: server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManager.java
##########
@@ -31,9 +33,14 @@
public static final int DEFAULT_PROXY_URL_PORT = 80;
public static final int DEFAULT_PROXY_SESSION_TIMEOUT = 300000; // 5 minutes
+ public static final int DEFAULT_NOVNC_PORT = 8080;
+
public static final String ALERT_SUBJECT = "proxy-alert";
public static final String CERTIFICATE_NAME = "CPVMCertificate";
+ public static final ConfigKey<Boolean> NoVncConsoleDefault = new ConfigKey<Boolean>("Advanced", Boolean.class, "novnc.console.default", "true",
+ "If true, noVNC console will be default console for virtual machines", true);
Review comment:
I think it should be disabled by default at least until all hypervisors tested working properly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani commented on a change in pull request
#3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r399053191
##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -478,7 +481,12 @@ private String composeConsoleAccessUrl(String rootUrl, VirtualMachine vm, HostVO
param.setClientTunnelSession(parsedHostInfo.third());
}
- sb.append("/ajax?token=" + encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+ if (param.getHypervHost() != null || !ConsoleProxyManager.NoVncConsoleDefault.value()) {
+ sb.append("/ajax?token=" + encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+ } else {
+ sb.append("/resource/noVNC/vnc_lite.html?port=" + ConsoleProxyManager.DEFAULT_NOVNC_PORT + "&token="
Review comment:
Wanted a simpler, minimalist UI, can add this when we get multi lingual keyboard working
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-605848568
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] davidjumani commented on a change in pull request
#3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r399052882
##########
File path: server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManager.java
##########
@@ -31,9 +33,14 @@
public static final int DEFAULT_PROXY_URL_PORT = 80;
public static final int DEFAULT_PROXY_SESSION_TIMEOUT = 300000; // 5 minutes
+ public static final int DEFAULT_NOVNC_PORT = 8080;
+
public static final String ALERT_SUBJECT = "proxy-alert";
public static final String CERTIFICATE_NAME = "CPVMCertificate";
+ public static final ConfigKey<Boolean> NoVncConsoleDefault = new ConfigKey<Boolean>("Advanced", Boolean.class, "novnc.console.default", "true",
+ "If true, noVNC console will be default console for virtual machines", true);
Review comment:
I've tested it on KVM, VMware and Xen and it works fine!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-613405024
@vladimirpetrov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-599980673
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov removed a comment on issue #3967: noVNC
console integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov removed a comment on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608304119
@blueorangutan help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-608306379
@blueorangutan help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] vladimirpetrov commented on issue #3967: noVNC console
integration
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609757448
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3967:
noVNC console integration
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #3967: noVNC console integration
URL: https://github.com/apache/cloudstack/pull/3967#discussion_r398863880
##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -478,7 +481,12 @@ private String composeConsoleAccessUrl(String rootUrl, VirtualMachine vm, HostVO
param.setClientTunnelSession(parsedHostInfo.third());
}
- sb.append("/ajax?token=" + encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+ if (param.getHypervHost() != null || !ConsoleProxyManager.NoVncConsoleDefault.value()) {
+ sb.append("/ajax?token=" + encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+ } else {
+ sb.append("/resource/noVNC/vnc_lite.html?port=" + ConsoleProxyManager.DEFAULT_NOVNC_PORT + "&token="
Review comment:
Why not using `vnc.html` which provides more functionalities? Briefly tested invoking it and got this extra functionalities:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services