You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/01 19:32:13 UTC
[jira] Created: (THRIFT-416) java.util.logging eats exceptions
without warning
java.util.logging eats exceptions without warning
-------------------------------------------------
Key: THRIFT-416
URL: https://issues.apache.org/jira/browse/THRIFT-416
Project: Thrift
Issue Type: Bug
Components: Library (Java)
Reporter: Jonathan Ellis
Using java.util.logging has two related problems.
One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
So thrift exceptions vanish without a trace which is bad.
Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694812#action_12694812 ]
David Reiss commented on THRIFT-416:
------------------------------------
Okay. Just be sure to update the wiki page on requirements. Also, the exception propagation patch should be a separate issue.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694771#action_12694771 ]
Michael Greene commented on THRIFT-416:
---------------------------------------
For what it's worth, all the users of the C# library I know of use log4net with it, but via a callback/delegate so as not to include the dependency in the library. It would be nice if this were possible with the Java library as well.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated THRIFT-416:
----------------------------------
Attachment: 0002-switch-to-log4j.patch
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694795#action_12694795 ]
David Reiss commented on THRIFT-416:
------------------------------------
bq. I would call "tell the developer what happened when there is a fatal error" a significant improvement in functionality.
Then let's add JUL configuration to the example server setup in the documentation. I'm sure everyone just copies from that anyway.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-416.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.1
I just committed this.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.1
>
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch, THRIFT-416-2.patch, thrift-416-v3.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated THRIFT-416:
----------------------------------
Attachment: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-416:
---------------------------------
Attachment: thrift-416-v3.patch
Here's a slightly modified version of the v3 patch. I think that we should treat all dependency jars the same way, so I deleted the explicit addition of log4j's jar to the classpath; it is assumed to be found in thrift.extra.cpath now instead. Also, I removed the "verbose=true" from the javac line to help keep the noise down.
What do you think of this version?
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch, THRIFT-416-2.patch, thrift-416-v3.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696590#action_12696590 ]
Jonathan Ellis commented on THRIFT-416:
---------------------------------------
+1
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch, THRIFT-416-2.patch, thrift-416-v3.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694804#action_12694804 ]
Jonathan Ellis commented on THRIFT-416:
---------------------------------------
> Then let's add JUL configuration to the example server setup in the documentation. I'm sure everyone just copies from that anyway.
I'm pretty sure even the most "enterprise" developers would prefer to only manage one set of logs.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated THRIFT-416:
----------------------------------
Attachment: THRIFT-416-2.patch
redid against head w/o exception propagation fixes.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch, THRIFT-416-2.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694734#action_12694734 ]
Bryan Duxbury commented on THRIFT-416:
--------------------------------------
The 0001 one patch does not apply to trunk anymore. Can you take a look and see why?
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694787#action_12694787 ]
Jonathan Ellis commented on THRIFT-416:
---------------------------------------
I would call "tell the developer what happened when there is a fatal error" a significant improvement in functionality.
I'm not aware of a way to use log4j as a backend.
Michael, I'm not sure how that would work here -- I can think of several ways to do something similar and all of them are clunkier than just shipping log4j.jar.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-416:
------------------------------------
Assignee: Jonathan Ellis
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694735#action_12694735 ]
Jonathan Ellis commented on THRIFT-416:
---------------------------------------
Damn. Git is tricky that way. :) Will have a look.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694801#action_12694801 ]
Bryan Duxbury commented on THRIFT-416:
--------------------------------------
I am very much pro whatever it is that will get my server log messages into log4j. I personally don't see any reason to use indirection, since I've never heard of anyone using anything other than log4j, but if slf4j is easy enough to incorporate, then I'd say go for it.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694783#action_12694783 ]
Luke Lu commented on THRIFT-416:
--------------------------------
I recommend that we use slf4j (http://www.slf4j.org/) and let people have choices of logging backends. Solr folks debated and switched to slf4j and people seem to be happy with it.
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694788#action_12694788 ]
Jonathan Ellis commented on THRIFT-416:
---------------------------------------
slf4j seems a significant increase in complexity. but I do not have a very "enterprise" brain. please correct me if I am wrong -- how would using Thrift look if we were to add that dependency?
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-416) java.util.logging eats exceptions
without warning
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694769#action_12694769 ]
David Reiss commented on THRIFT-416:
------------------------------------
001 has some odd changes to whitespace. Please revert them.
I'm hesitant to add a mandatory dependency to Thrift without significant improvements in functionality. Is it possible to configure JUL at runtime to use log4j as a backend or something like that? Are there JUL adapters for log4j classes so we can just allow the servers to receive their logger as an argument rather than instantiate a JUL logger?
> java.util.logging eats exceptions without warning
> -------------------------------------------------
>
> Key: THRIFT-416
> URL: https://issues.apache.org/jira/browse/THRIFT-416
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java)
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-allow-exceptions-to-propagate-up-where-feasible.-on.patch, 0002-switch-to-log4j.patch
>
>
> Using java.util.logging has two related problems.
> One is that virtually no java project in the wild uses it. Everyone uses the more advanced log4j.
> Two is that unlike log4j, java.util.logging does not warn you when it is swallowing errors because it has not been configured.
> So thrift exceptions vanish without a trace which is bad.
> Here is a patch to switch to log4j.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.