[jira] Commented: (SOLR-1147) QueryElevationComponent : updating elevate.xml through HTTP

["Otis Gospodnetic (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709241#action_12709241 ] 

Otis Gospodnetic commented on SOLR-1147:
----------------------------------------

I'm +1 for the idea of being able to push elevate config (and really other config files, too!) from a remote system into Solr.
I only skimmed the patch.
It would be good to add a unit test.  Could you do that?
You'll also want to add the ASL on top of the source code.  It may also be good to remove eZ publish references from the Javadoc (having that in the javadoc doesn't really help developers using Solr)
Is that "" at the end of QueryElevationAdministrationRequestHandler.class + ""  really needed?
Please note the bit about the code formatting here:
http://wiki.apache.org/solr/HowToContribute#head-59ae13df098fbdcc46abdf980aa8ee76d3ee2e3b

Thanks!


> QueryElevationComponent : updating elevate.xml through HTTP
> -----------------------------------------------------------
>
>                 Key: SOLR-1147
>                 URL: https://issues.apache.org/jira/browse/SOLR-1147
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.3, 1.4, 1.5
>         Environment: Any
>            Reporter: Nicolas Pastorino
>            Priority: Minor
>         Attachments: QueryElevationAdministrationRequestHandler.java, QueryElevationAdministrationRequestHandler.java
>
>
> If one wants to update the configuration file for the QueryElevationComponent, direct edition of the file is mandatory. Currently the process seems to be : 
> # Replace elevate.xml in Solr's dataDir
> # Commit. It appears that when having elevate.xml in Solr's dataDir, and solely in this case, commiting triggers a reload of elevate.xml. This does not happen when elevate.xml is stored in Solr's conf dir.
> As a system using Solr, i would find handy to be able to push an updated elevate.xml file/XML through HTTP, with an automatic reload of it. This would remove the currently mandatory requirement of having a direct access to the elevate.xml file, allowing more distributed architectures. This would also increase the Query Elevation system's added value by making it dynamic, configuration-wise.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.