You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/23 09:35:14 UTC

[GitHub] [flink] godfreyhe opened a new pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

godfreyhe opened a new pull request #14168:
URL: https://github.com/apache/flink/pull/14168


   
   ## What is the purpose of the change
   
   *In 1.11, `HiveTableSource` uses `ContinuousFileMonitoringFunction` with given `globalModificationTime`, while in `ContinuousFileMonitoringFunction#initializeState` the state restore logic always checks whether `globalModificationTime` is equal to `Long.MIN_VALUE`. The correct logic should be checking whether the `globalModificationTime` is equal to the initialized `globalModificationTime`.*
   
   
   ## Brief change log
   
     - *Check whether the globalModificationTime is equal to the initialized  globalModificationTime*
   
   
   ## Verifying this change
   
   
   
   This change added tests and can be verified as follows:
   
     - *Extended ContinuousFileProcessingTest to verify the bug*
    
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732064161


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937",
       "triggerID" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4e66feafd0f4f8c00e024000ed055c44b65bbc51 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732042805


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4e66feafd0f4f8c00e024000ed055c44b65bbc51 (Mon Nov 23 09:38:14 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe merged pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
godfreyhe merged pull request #14168:
URL: https://github.com/apache/flink/pull/14168


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732064161


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937",
       "triggerID" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9947",
       "triggerID" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4e66feafd0f4f8c00e024000ed055c44b65bbc51 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937) 
   * ac9e64f86294f088a94e41ad1c7f165abddb24ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9947) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732064161


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937",
       "triggerID" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4e66feafd0f4f8c00e024000ed055c44b65bbc51 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937) 
   * ac9e64f86294f088a94e41ad1c7f165abddb24ad UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] godfreyhe commented on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732548327


   My private azure is success, https://dev.azure.com/godfreyhe/godfreyhe-flink/_build/results?buildId=82&view=results. I will merge this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732064161


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4e66feafd0f4f8c00e024000ed055c44b65bbc51 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732064161


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937",
       "triggerID" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9947",
       "triggerID" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf651cef1298aae1876a5319b19cbdde47e0e14f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cf651cef1298aae1876a5319b19cbdde47e0e14f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4e66feafd0f4f8c00e024000ed055c44b65bbc51 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937) 
   * ac9e64f86294f088a94e41ad1c7f165abddb24ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9947) 
   * cf651cef1298aae1876a5319b19cbdde47e0e14f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732064161


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937",
       "triggerID" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9947",
       "triggerID" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf651cef1298aae1876a5319b19cbdde47e0e14f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9967",
       "triggerID" : "cf651cef1298aae1876a5319b19cbdde47e0e14f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ac9e64f86294f088a94e41ad1c7f165abddb24ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9947) 
   * cf651cef1298aae1876a5319b19cbdde47e0e14f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14168:
URL: https://github.com/apache/flink/pull/14168#issuecomment-732064161


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9937",
       "triggerID" : "4e66feafd0f4f8c00e024000ed055c44b65bbc51",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9947",
       "triggerID" : "ac9e64f86294f088a94e41ad1c7f165abddb24ad",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cf651cef1298aae1876a5319b19cbdde47e0e14f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9967",
       "triggerID" : "cf651cef1298aae1876a5319b19cbdde47e0e14f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cf651cef1298aae1876a5319b19cbdde47e0e14f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9967) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] JingsongLi commented on a change in pull request #14168: [FLINK-20277] Fix that ContinuousFileMonitoringFunction cannot restore from failure

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #14168:
URL: https://github.com/apache/flink/pull/14168#discussion_r528651004



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
##########
@@ -96,6 +96,9 @@
 	/** The maximum file modification time seen so far. */
 	private volatile long globalModificationTime;
 
+	/** store the initialized value of globalModificationTime */
+	private volatile long initializedGlobalModificationTime;

Review comment:
       volatile -> final




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org