You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 03:23:35 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #11948: [FLINK-17467] Align channels on savepoint in UC mode
zhijiangW commented on a change in pull request #11948:
URL: https://github.com/apache/flink/pull/11948#discussion_r425544862
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -469,7 +469,9 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int backlog) throws IOEx
if (notifyReceivedBarrier != null) {
receivedCheckpointId = notifyReceivedBarrier.getId();
- listener.notifyBarrierReceived(notifyReceivedBarrier, channelInfo);
+ if (notifyReceivedBarrier.isCheckpoint()) {
Review comment:
I guess the above `receivedCheckpointId = notifyReceivedBarrier.getId();` should also be placed inside this condition, because `receivedCheckpointId` only works for checkpoint now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org