[GitHub] [incubator-superset] pkdotson commented on a change in pull request #10416: feat(checkbox): update checkbox to sip-34 design

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #10416:
URL: https://github.com/apache/incubator-superset/pull/10416#discussion_r459739364



##########
File path: superset-frontend/src/components/Checkbox.jsx
##########
@@ -32,15 +32,17 @@ export default function Checkbox({ checked, onChange, style }) {
         role="button"
         tabIndex={0}
         className={`fa fa-check ${
-          checked ? 'text-primary' : 'text-transparent'
+          checked ? 'text-white' : 'text-transparent'
         }`}
         onClick={() => {
           onChange(!checked);
         }}
         style={{
-          border: '1px solid #aaa',
+          border: `${checked ? '1px solid #20A7C9' : '1px solid #aaa'}`,
           borderRadius: '2px',
           cursor: 'pointer',
+          boxShaddow: 'inset 1px 0px 0px #E0E0E0',
+          backgroundColor: `${checked ? '#20A7C9' : 'transparent'}` 

Review comment:
       sounds like a good idea to me. @rusackas any thoughts on this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org