You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org> on 2007/05/05 23:09:26 UTC
[jira] Created: (MECLIPSE-266) plugin applies java facet to ear
project
plugin applies java facet to ear project
----------------------------------------
Key: MECLIPSE-266
URL: http://jira.codehaus.org/browse/MECLIPSE-266
Project: Maven 2.x Eclipse Plugin
Issue Type: Bug
Components: WTP support
Affects Versions: 2.3
Environment: Windows XP
Reporter: Srepfler Srgjan
In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
<faceted-project>
<fixed facet="jst.java"/>
<fixed facet="jst.ear"/>
<installed facet="jst.ear" version="1.3"/>
<installed facet="jst.java" version="1.4"/>
</faceted-project>
This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101793 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
As far as I can see <groupId>javaee</groupId><artifactId>javaee-api</artifactId> is not in the repository and by the code Arnaud posted it would seem one should refer to the geronimo libraries. One issue with that as well, it would seem all libs of geronimo are RC's, will those work as well?
Thanks for all the usefull feedback guys!
Srgjan
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Thierry Levieux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101751 ]
Thierry Levieux commented on MECLIPSE-266:
------------------------------------------
The maven-ear-plugin does not generate the ear facet version (see my last comment).
What's your maven-eclipse-plugin version ?
Two comments:
- The jboss j2ee library is not managed by the tool that resolves the jee version, I suppose because jboss uses a legacy version ...
- I'm not sure the j2ee process resolution is transitive, you probably have to declare the j2ee library
within your EAR dependencies ... what I do myself.
So if you add the following dependency in your ear and then run mvn eclipe:eclipse, it should work:
<dependency>
<groupId>javaee</groupId>
<artifactId>javaee-api</artifactId>
<version>1.4</version>
<scope>provided</scope>
</dependency>
Thierry
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102110 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
You are right when you say that it's the concern of the eclipse plugin to generate eclipse project files.
The eclipse always was able to generate a project configuration, what I'm reporting is a bug, when generating a project for a EAR artifact it's applying also a Java project facet which is incompatible with WTP. In WTP a EAR project must not have a Java facet.
That said I think it's not a good choice to apply dependencies to a EAR because it's not a Java project.
Again why is the plugin using these strange dependency analysis on the project if it's enough to either look at the ear configuration of the ear module or eventually the schema version for the application.xml file.
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101866 ]
Arnaud Heritier commented on MECLIPSE-266:
------------------------------------------
I believe in you ;-)
I didn't develop this part and I never used ear feature in eclipse WTP. I use only the war in tomcat.
We'll try to see if in our tests we have a running sample of a little ear to deploy it in eclipse.
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier updated MECLIPSE-266:
-------------------------------------
Fix Version/s: 2.5.1
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
> Fix For: 2.5.1
>
> Attachments: MECLIPSE-266-2.5.patch, MECLIPSE-266-maven-eclipse-plugin.patch, MECLIPSE-266.patch
>
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101530 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
prior to your comment I didn't have displayName, description nor version as configuration tags,
I've added this but still the plugin applies the java facet.
<plugin>
<artifactId>maven-ear-plugin</artifactId>
<configuration>
<displayName>CSAIEAR</displayName>
<description>CSAI EAR module</description>
<version>1.4</version>
<archive>
<manifest>
<addClasspath>true</addClasspath>
</manifest>
</archive>
</configuration>
</plugin>
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101819 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
I've tried with:
<dependency>
<groupId>geronimo-spec</groupId>
<artifactId>geronimo-spec-j2ee</artifactId>
<version>1.4-rc4</version>
</dependency>
but still the java facet is applied on the EAR. I'm currenty applying this dependency to the EJB module, should I apply it to the EAR?
Where can I download
<dependency>
<groupId>javax</groupId>
<artifactId>j2ee</artifactId>
<version>1.4</version>
<scope>provided</scope>
</dependency>
The repo has the entry but no artifacts (licencing issues probably) but no link to the site where to download it.
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Tionan Lim (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tionan Lim updated MECLIPSE-266:
--------------------------------
Attachment: MECLIPSE-266.patch
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
> Attachments: MECLIPSE-266.patch
>
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102327 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
Hi Thierry,
I agree with most points in your comment, I also have the feeling it will take some time as making new artifacts is always a time consuming issue and with stretched resources low priority issues don't get the right measure of care. I did not understand the ant use case but I don't have any issue with that.
As far as my project is concerned, I personally dropped the use of eclipse a while ago because of validations issues one of which is filed with this bug.
This bug is one pain it the behind but I personally don't find it critical. As I said I fix this problem by editing the file by hand and removing the java facet. My project builds fine with maven and having this issue fixed would only help me in being able to use it with eclipse friction free. Of course I would say that not too many people use maven and eclipse together, otherwise this issue would have been noticed earlier and fixed by now (I've noticed this issue perhaps a year ago and filed this bug only recently, I still don't understand what were people doing in the mean time).
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101834 ]
Arnaud Heritier commented on MECLIPSE-266:
------------------------------------------
You can see in this class that the java facet is always used. We just add the ear, war, .. facet if the project has a different packaging
http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/eclipse/writers/wtp/EclipseWtpFacetsWriter.java
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Thierry Levieux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101808 ]
Thierry Levieux commented on MECLIPSE-266:
------------------------------------------
OK, javaee-api is java EE5 related (what I use !). Sorry.
Use this one instead :
<dependency>
<groupId>javax</groupId>
<artifactId>j2ee</artifactId>
<version>1.4</version>
<scope>provided</scope>
</dependency>
It MUST work !
I'm waiting for a successful feedback !!!
Thierry
N.B.: I think geronimo is supported because its artifact version tracks the j2ee version. JBoss doesn't...
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Thierry Levieux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102100 ]
Thierry Levieux commented on MECLIPSE-266:
------------------------------------------
"Why would I add a dependency to anything if there is already a version tag in the ear plugin specification?"
I think maven has been designed so as the plugins are as agnostics as possible, to avoid cross plugins
dependencies. By agnostic I mean they don't know about each other (maybe one exception is maven-compiler-plugin).
Please correct me if I am wrong...
Personally, I always start thinking of plugins as functionalities, so you can easily answer the former question:
- I need to generate an eclipse project that represents an EAR.
- who is responsible for generating the artifacts (.project .classpath .settings..) ?
- ear plugin ? No, it is a packaging tool.
- eclipse plugin ? Yes, it generates my eclipse artifacts.
Now you can forget your ear/ant/tomcat/coffee... plugins !
If you have an issue with wtp, the responsibles are either the eclipse plugin itself (a bug), its configuration
or the project attributes (i.e jar packaging instead of ear packaging, for instance)...
By the way, have you succeed in generating your project ?
Thierry
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Thierry Levieux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102138 ]
Thierry Levieux commented on MECLIPSE-266:
------------------------------------------
- Regarding the "strange dependency analysis", I am a little confused too.
One solution would consist in adding the ear version within the *eclipse plugin* configuration.
In my opinion this is not a good solution because an ear version attribute depends on the project context:
the ear version has no sense if you generate a war or an ejb wtp project.
On the other hand I don't agree to look at the *ear plugin* at all. Cross plugin dependencies must be avoid
as much as possible. For instance, what's happen if you decide to use a proprietary/commercial
*ear plugin* instead of the default one ? The *eclipse plugin* is broken !
So I think the dependency analysis is a not-so-bad solution.
However my favourite solution would be a dedicated plugin for each wtp artifact (ear, war, ejb), with their dedicated
attributes (j2ee version, servlet version, ejb version). No more dependencies analysis.
A last think, don't be afraid with duplicate attributes accross plugins (a consequence of the separation of concerns).
I recommend you to use ant annotations (<version>${ear.version}<version> for instance), with global properties located
in a "master" pom.
- Regarding the Java facet, I agree with you (a bug ?).
And what's about your project ? Have you succeed ?
Thierry
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier closed MECLIPSE-266.
------------------------------------
Resolution: Fixed
Patch applied in maven-eclipse-plugin 2.5.1-20080327.221549-3. Thx.
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
> Assignee: Arnaud Heritier
> Fix For: 2.5.1
>
> Attachments: MECLIPSE-266-2.5.patch, MECLIPSE-266-maven-eclipse-plugin.patch, MECLIPSE-266.patch
>
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101663 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
Forgot to mention, while the EAR module itself doesn't declare any direct j2ee lib, the EJB module does:
<dependency>
<groupId>jboss</groupId>
<artifactId>jboss-j2ee</artifactId>
</dependency>
which inherit from the parent:
<dependency>
<groupId>jboss</groupId>
<artifactId>jboss-j2ee</artifactId>
<version>4.0.2</version>
<scope>provided</scope>
</dependency>
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Stefan Bley (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Bley updated MECLIPSE-266:
---------------------------------
Attachment: MECLIPSE-266-2.5.patch
Patch for version 2.5
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
> Attachments: MECLIPSE-266-2.5.patch, MECLIPSE-266-maven-eclipse-plugin.patch, MECLIPSE-266.patch
>
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101842 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
But this is wrong!
I don't see how you are able to do project building in eclipse if the validation of the project fails. WTP consistently over versions refuses to accept a java facet on a EAR project and what worse you can't remove the java facet on a project and one is forced to remove the xml element manually.
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Thierry Levieux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101309 ]
Thierry Levieux commented on MECLIPSE-266:
------------------------------------------
Check the "version" attribute of the configuration group:
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-ear-plugin</artifactId>
<version>2.3</version>
<configuration>
<displayName></displayName>
<description></description>
<version>your ear version</version>
...
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102074 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
Why would I add a dependency to anything if there is already a version tag in the ear plugin specification?
Why all the heuristics on the j2ee implementation (that are limited as there are many implementations and some are having licence issues) if someone already declares things in the pom, is DRY no longer valid?
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Stefan Bley (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=128496#action_128496 ]
Stefan Bley commented on MECLIPSE-266:
--------------------------------------
Although there is a patch, this issue is still marked "open". Why is that? Is it resolved in versions 2.4 and 2.5?
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
> Attachments: MECLIPSE-266-maven-eclipse-plugin.patch, MECLIPSE-266.patch
>
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101752 ]
Arnaud Heritier commented on MECLIPSE-266:
------------------------------------------
FYI the code used to resolve JEE versions is here : http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/JeeUtils.java
If you want to have a look at it and propose a patch ;-)
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MECLIPSE-266) plugin applies java
facet to ear project
Posted by "Stefan Bley (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=128496#action_128496 ]
stevy edited comment on MECLIPSE-266 at 3/25/08 3:36 AM:
---------------------------------------------------------------
Although there is a patch, this issue is still marked "open". Why is that? Is it resolved in versions 2.4 and 2.5?
Edit:
Looking through version 2.5 of org.apache.maven.plugin.eclipse.writers.wtp.EclipseWtpFacetsWriter I see that the Java facet is again assigned to all types of WTP projects (war, ejb and also ear).
Would you please take care NOT to assign the Java facet to EAR projects.
Stefan
was (Author: stevy):
Although there is a patch, this issue is still marked "open". Why is that? Is it resolved in versions 2.4 and 2.5?
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
> Attachments: MECLIPSE-266-maven-eclipse-plugin.patch, MECLIPSE-266.patch
>
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Thierry Levieux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101609 ]
Thierry Levieux commented on MECLIPSE-266:
------------------------------------------
Sorry, I was probably tired this day, facets are generated by maven-eclipse-plugin,
not maven-ear-plugin !!!
Also, you're right, these parameters seem to be wrong (Crtl-v / Crtl-c ?!).
Which maven-eclipse-plugin & eclipse-wtp versions are you using ?
I know that one way the plugin applies the ear version is to find the j2ee
version in the dependencies (javaee-api", "j2ee" or "geronimo-spec-j2ee).
Do you have any of them in your pom ?
Thierry
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Thierry Levieux (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101884 ]
Thierry Levieux commented on MECLIPSE-266:
------------------------------------------
Yes sun's libraries have to be installed manually due to licensing issues...
See http://maven.apache.org/guides/mini/guide-coping-with-sun-jars.html
and http://maven.apache.org/guides/mini/guide-installing-3rd-party-jars.html
I think you have to apply the j2ee dependency into your EAR module because,
as I said in a previous message, I am not sure the j2ee version resolution process is transitive.
After all, I think it's quite constitent to declare the j2ee version within the ear module.
Thierry
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-266) plugin applies java facet to ear
project
Posted by "Srepfler Srgjan (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_101661 ]
Srepfler Srgjan commented on MECLIPSE-266:
------------------------------------------
I declare the maven ear plugin in the parent pom:
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-ear-plugin</artifactId>
<version>2.3</version>
</plugin>
</plugins>
</build>
as far as the eclipse plugin version it's 2.3 with wtpversion set to 1.5
> plugin applies java facet to ear project
> ----------------------------------------
>
> Key: MECLIPSE-266
> URL: http://jira.codehaus.org/browse/MECLIPSE-266
> Project: Maven 2.x Eclipse Plugin
> Issue Type: Bug
> Components: WTP support
> Affects Versions: 2.3
> Environment: Windows XP
> Reporter: Srepfler Srgjan
>
> In .settings/org.eclipse.wst.common.project.facet.core.xml of the EAR module I'm getting this:
> <faceted-project>
> <fixed facet="jst.java"/>
> <fixed facet="jst.ear"/>
> <installed facet="jst.ear" version="1.3"/>
> <installed facet="jst.java" version="1.4"/>
> </faceted-project>
> This is a wrong facet on a EAR module and I can't compile if I don't edit this file manually (I can't do it from the project properties - facets dialog)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira