You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "apupier (via GitHub)" <gi...@apache.org> on 2025/10/23 07:29:17 UTC

[PR] Replace deprecated static attributes by setters in http component tests [camel-quarkus]

apupier opened a new pull request, #7870:
URL: https://github.com/apache/camel-quarkus/pull/7870

   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace deprecated static attributes by setters in http component tests [camel-quarkus]

Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #7870:
URL: https://github.com/apache/camel-quarkus/pull/7870#issuecomment-3436239202

   I think I tried this in the past and it didn't work. I never got to the bottom of what was going on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace deprecated static attributes by setters in http component tests [camel-quarkus]

Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #7870:
URL: https://github.com/apache/camel-quarkus/pull/7870#issuecomment-3436489858

   seems the culprit in inside httpclient where there is an HttpClient$Delegate which is used but the Delegate is looking only in the Attributes and not looking to the getters.
   
   https://github.com/apache/httpcomponents-client/blob/f0afb8e6b73ed74c785747dea4dec43383c3d5db/httpclient5/src/main/java/org/apache/hc/client5/http/protocol/HttpClientContext.java#L601
   
   https://github.com/apache/httpcomponents-client/blob/f0afb8e6b73ed74c785747dea4dec43383c3d5db/httpclient5/src/main/java/org/apache/hc/client5/http/protocol/HttpClientContext.java#L173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace deprecated static attributes by setters in http component tests [camel-quarkus]

Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on PR #7870:
URL: https://github.com/apache/camel-quarkus/pull/7870#issuecomment-3436439060

   very same issue in Camel core when updating the code to use the setters: https://github.com/apupier/camel/pull/new/deprecatedAttributeHttp
   
   ```
   org.opentest4j.AssertionFailedError: expected: <200> but was: <401>
   	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
   	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
   	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
   	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
   	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
   	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
   	at org.apache.camel.component.http.BaseHttpsTest.assertHeaders(BaseHttpsTest.java:43)
   	at org.apache.camel.component.http.BaseHttpsTest.assertExchange(BaseHttpsTest.java:38)
   	at org.apache.camel.component.http.HttpsAuthenticationTest.httpsGetWithHttpCache(HttpsAuthenticationTest.java:120)
   	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Replace deprecated static attributes by setters in http component tests [camel-quarkus]

Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier closed pull request #7870: Replace deprecated static attributes by setters in http component tests
URL: https://github.com/apache/camel-quarkus/pull/7870


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org