You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/13 11:39:06 UTC

[GitHub] [airflow] pierrejeambrun opened a new issue #21545: Add Go to docker images

pierrejeambrun opened a new issue #21545:
URL: https://github.com/apache/airflow/issues/21545


   ### Description
   
   Following https://github.com/apache/airflow/pull/20386 we are now supporting execution of Beam Pipeline written in Go.
   
   We might want to add Go to the images.
   
   Beam Go SDK first stable release is `v2.33.0` and requires `Go v1.16` minimum:
   
   ### Use case/motivation
   
   This way people running airflow from docker can build/run their go pipelines.
   
   ### Related issues
   
   Issue:
   
   PR:
   https://github.com/apache/airflow/pull/20386
   
   Issue:
   https://github.com/apache/airflow/issues/20283
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038045104


   The worst case we can add instructions/examples how to do it in our "extending image" chapter. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1067914514


   Feel free.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038042549


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038471499


   I think we should add the guide to the "Recipes" section in `docker-stack` documentation package. https://airflow.apache.org/docs/docker-stack/recipes.html
   
   We already have a guide on how to install additional tools:
   * Google Cloud SDK, which is needed for GKEPodOperator, DataflowStartSqlJobOperator, and others.
   * JRE, which is needed for DataflowCreateJavaJobOperator, and many others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038042549


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1052630328


   Agree  - added "good first issue" label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038044791


   I will see how much go will add to the size of the image and decide :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pierrejeambrun commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038044332


   @potiuk as requested, here is the issue :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pierrejeambrun commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038044332


   @potiuk as requested, here is the issue :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038044791






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038045104


   The worst case we can add instructions in our "extending image" chapter. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pierrejeambrun edited a comment on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
pierrejeambrun edited a comment on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1067689905


   Hello @potiuk,
   
   I would be glad to help with the go recipe.
   
   Let me know if you want me to work on it :)
   
   Best,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj closed issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #21545:
URL: https://github.com/apache/airflow/issues/21545


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038471499


   I think we should add the guide to the "Recipes" section in `docker-stack` documentation package. https://airflow.apache.org/docs/docker-stack/recipes.html
   
   We already have a guide on how to install additional tools:
   * Google Cloud SDK, which is needed for GKEPodOperator, DataflowStartSqlJobOperator, and others.
   * JRE, which is needed for DataflowCreateJavaJobOperator, and many others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1038045104


   The worst case we can add instructions/examples how to do it in our "extending image" chapter. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pierrejeambrun commented on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
pierrejeambrun commented on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1067689905


   Hello @potiuk,
   
   I would be glad to give a hand on this one for the go recipe.
   
   Let me know if you want me to work on it :)
   
   Best,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pierrejeambrun edited a comment on issue #21545: Add Go to docker images

Posted by GitBox <gi...@apache.org>.
pierrejeambrun edited a comment on issue #21545:
URL: https://github.com/apache/airflow/issues/21545#issuecomment-1067689905


   Hello @potiuk,
   
   I would be glad to help on this one for the go recipe.
   
   Let me know if you want me to work on it :)
   
   Best,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org