You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by nsuke <gi...@git.apache.org> on 2016/02/10 11:07:09 UTC

[GitHub] thrift pull request: THRIFT-2877 Generate hashCode using primitive...

Github user nsuke commented on the pull request:

    https://github.com/apache/thrift/pull/448#issuecomment-182289601
  
    Hi @roshan, sorry for the delay, I've just discovered this.
    While this change makes sense in general, I have one concern.
    
    > The TBaseHelper.hashCode methods are the Java 8 implementations of hashCode for
    those types.
    
    Does this involve any code-level transplant, like copy-paste ?
    In that case I'm afraid we have no way to incorporate this, as OpenJDK is GPL (let alone Oracle JDK disassemble).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---