You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2025/04/20 07:33:46 UTC

[PR] refactor(services/fs): extract this logic as new util functions [opendal]

caicancai opened a new pull request, #6061:
URL: https://github.com/apache/opendal/pull/6061

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking-changes` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(services/fs): extract this logic as new util functions [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed pull request #6061: refactor(services/fs): extract this logic as new util functions
URL: https://github.com/apache/opendal/pull/6061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(services/fs): extract this logic as new util functions [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6061:
URL: https://github.com/apache/opendal/pull/6061#issuecomment-2817045408

   Thank you for this, but I don't think refactoring logic only written twice is meaningful.
   
   I going to close this one. Welcome implementing new features or fixing existing bugs instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(services/fs): extract this logic as new util functions [opendal]

Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #6061:
URL: https://github.com/apache/opendal/pull/6061#issuecomment-2817047726

   > Thank you for this, but I don't think refactoring logic only written twice is meaningful.
   > 
   > I going to close this one. Welcome implementing new features or fixing existing bugs instead.
   
   Thank you for your reply, I will continue to learn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org