You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/12/03 01:43:55 UTC

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #722: [SEDONA-208] Use Spark RuntimeConfig in SedonaConf

jiayuasu commented on code in PR #722:
URL: https://github.com/apache/incubator-sedona/pull/722#discussion_r1038660894


##########
sql/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/TraitJoinQueryExec.scala:
##########
@@ -61,13 +61,9 @@ trait TraitJoinQueryExec extends TraitJoinQueryBase {
     if (sedonaConf.getJoinApproximateTotalCount == -1) {
       if (sedonaConf.getJoinSparitionDominantSide == JoinSparitionDominantSide.LEFT) {
         leftShapes.analyze()
-        sedonaConf.setJoinApproximateTotalCount(leftShapes.approximateTotalCount)

Review Comment:
   I also forgot why it was set but not used...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org