[Bug 123961] New: libsvx.so won't link because of inconsistence in declaration of ColorControl::SetCurColorSelect

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123961

            Bug ID: 123961
        Issue Type: DEFECT
           Summary: libsvx.so won't link because of inconsistence in
                    declaration of ColorControl::SetCurColorSelect
           Product: General
           Version: 4.0.1
          Hardware: Other
                OS: Solaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ui
          Assignee: issues@openoffice.apache.org
          Reporter: petr.sumbera@oracle.com
                CC: issues@openoffice.apache.org

Created attachment 82209
  --> https://issues.apache.org/ooo/attachment.cgi?id=82209&action=edit
possible fix

When building using Solaris Studio compiler 12.3. I get following error:

[ build LNK ] Library/libsvx.so
Undefined                       first referenced
 symbol                             in file
void svx::sidebar::ColorControl::SetCurColorSelect(const Color,const bool)
/builds/psumbera/aoo/components/openoffice/build/i86/main/solver/401/unxsoli4.pro/workdir/CxxObject/svx/source/sidebar/tools/ColorPopup.o
ld: fatal: symbol referencing errors

---

This is because of following inconsistence.

Header file declares:

void ColorControl::SetCurColorSelect (const Color aCol, const bool bAvailable)

while ColorControl.cxx has:

void ColorControl::SetCurColorSelect (Color aCol, bool bAvailable)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123961] libsvx.so won't link because of inconsistence in declaration of ColorControl::SetCurColorSelect

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123961

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ACCEPTED
                 CC|                            |hdu@apache.org
           Assignee|issues@openoffice.apache.or |hdu@apache.org
                   |g                           |
     Ever confirmed|0                           |1

--- Comment #1 from hdu@apache.org <hd...@apache.org> ---
Thanks for the patch! Actually I'd prefer if the declaration was adjusted not
to use const for non-reference/non-pointer types, because that is an
implementation detail of the function which is irrelevant its users. Some
compilers even warn about this.

Does your compiler work when you remove the const from the
non-reference/non-pointer types in the *hxx file? If the constness aspect is
important it should go where it actually belongs: into the function definition
(in the *cxx file). Does your compiler allow, that the declaration uses the
non-const variant in the declaration and the const variant in the definition?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123961] libsvx.so won't link because of inconsistence in declaration of ColorControl::SetCurColorSelect

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123961

Petr Sumbera <pe...@oracle.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82209|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.