You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "gabotorresruiz (via GitHub)" <gi...@apache.org> on 2026/02/11 16:10:09 UTC

[PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

gabotorresruiz opened a new pull request, #37897:
URL: https://github.com/apache/superset/pull/37897

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR standardizes CRUD list page action buttons to a consistent order: Edit --> <some_ohter_actions> --> Delete
   
   Also fixed some react memoization warnings, some missing hook dependencies, camelCase lint violations, and ESLint config issues for .ts plugin loading and refactor/improve `hooks.test.tsx` with proper coverage for all exported hooks
   
   ### BEFORE/AFTER SCREENSHOTS
   <!--- Skip this if not applicable -->
   **Before:**
   <img width="229" height="125" alt="Screenshot 2026-02-11 at 12 44 13" src="https://github.com/user-attachments/assets/e987ede4-4c26-494d-a8c7-ff4517d158f6" />
   
   **After:**
   <img width="161" height="98" alt="Screenshot 2026-02-11 at 13 06 36" src="https://github.com/user-attachments/assets/e38c834e-3659-4575-9720-a80186c2b660" />
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   1. Visit any CRUD view and verify action buttons show as Edit --> <some_ohter_actions> --> Delete (left to right)
   2. Verify each action still works
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3923526409

   🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/22160058509) for [932fcbf](https://github.com/apache/superset/commit/932fcbf)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3923696881

   @gabotorresruiz unsure if saved queries should follow the same convention of <edit> <something> <delete> but it currently isn't.
   
   <img width="975" height="161" alt="Screenshot 2026-02-18 at 3 13 31 PM" src="https://github.com/user-attachments/assets/03569d0d-2f52-4a52-a1ba-c22f4b44d060" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #37897:
URL: https://github.com/apache/superset/pull/37897#discussion_r2794334846


##########
superset-frontend/.eslintrc.minimal.js:
##########
@@ -17,6 +17,9 @@
  * under the License.
  */
 
+// Register TypeScript require hook so ESLint can load .ts plugin files
+require('tsx/cjs');
+
 /**

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>TypeScript ESLint forbids require() style imports</b></div>
   <div id="fix">
   
   The `require('tsx/cjs')` call violates the `@typescript-eslint/no-require-imports` rule. Replace with ES6 `import` syntax to comply with TypeScript linting standards.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ````suggestion
   // Register TypeScript require hook so ESLint can load .ts plugin files
   import 'tsx/cjs';
    
   /**
   ````
   
   </div>
   </details>
   
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #70fb97</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3885464871

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 64ba5edab548b928c5743f9808368e831400f94c |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/698ca9e264fc73000891af29 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-37897--superset-docs-preview.netlify.app](https://deploy-preview-37897--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTM3ODk3LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.EnVyafxVTL24ELFU5Hn7vm4lWsmjH8m_s1jkYckznMM)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-37897--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #37897:
URL: https://github.com/apache/superset/pull/37897#discussion_r2824885803


##########
superset-frontend/src/views/CRUD/hooks.ts:
##########
@@ -796,8 +829,8 @@ export function useDatabaseValidation() {
                 ];
                 return allowed.includes(err.error_type) || onCreate;
               })
-              .reduce((acc: JsonObject, err_2: any) => {
-                const { message, extra } = err_2;
+              .reduce((acc: JsonObject, err2: any) => {

Review Comment:
   nit: `err2` isn't super descriptive. Should rename to something more descriptive in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3924594774

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #37897:
URL: https://github.com/apache/superset/pull/37897#discussion_r2824880294


##########
superset-frontend/src/views/CRUD/hooks.test.tsx:
##########
@@ -16,245 +16,724 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { renderHook } from '@testing-library/react-hooks';
+import { renderHook, act } from '@testing-library/react-hooks';

Review Comment:
   nit: isn't `@testing-library/react-hooks` being deprecated? May need to fix this later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3885430243

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #37897:
URL: https://github.com/apache/superset/pull/37897#discussion_r2825472200


##########
superset-frontend/src/views/CRUD/hooks.test.tsx:
##########
@@ -16,245 +16,724 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { renderHook } from '@testing-library/react-hooks';
+import { renderHook, act } from '@testing-library/react-hooks';

Review Comment:
   I agree, but we need to migrate to React 18 first to be able to fix this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #37897:
URL: https://github.com/apache/superset/pull/37897#discussion_r2824887486


##########
superset-frontend/src/views/CRUD/hooks.ts:
##########
@@ -816,8 +849,8 @@ export function useDatabaseValidation() {
                 }
 
                 if (extra?.missing) {
-                  extra.missing.forEach((field_1: string) => {
-                    acc[field_1] = 'This is a required field';
+                  extra.missing.forEach((field1: string) => {

Review Comment:
   nit: same here. `field1` isn't super descriptive on what it is? Maybe in the future `missingField`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3888483823

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #37897:
URL: https://github.com/apache/superset/pull/37897#discussion_r2794175617


##########
superset-frontend/src/pages/RowLevelSecurityList/index.tsx:
##########
@@ -74,29 +74,31 @@ function RowLevelSecurityList(props: RLSProps) {
     true,
   );
 
-  function handleRuleEdit(rule: null) {
+  const handleRuleEdit = useCallback((rule: null) => {

Review Comment:
   **Suggestion:** The `handleRuleEdit` callback parameter is typed as `null`, yet it is called with actual rule objects in the code. This incorrect type annotation misleads the type system and can cause TypeScript compile-time errors or loss of type safety when using the function, since valid RLS rule objects do not conform to the declared type. [type error]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ Misleading types for `handleRuleEdit` in RowLevelSecurityList.
   - ⚠️ TypeScript cannot validate rule argument structure.
   - ⚠️ Weaker editor IntelliSense for edit-handler consumers.
   ```
   </details>
   
   ```suggestion
     const handleRuleEdit = useCallback((rule: RLSObject | null) => {
   ```
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Open `superset-frontend/src/pages/RowLevelSecurityList/index.tsx` and locate
   `handleRuleEdit` definition at line 77, typed as `(rule: null) => void`.
   
   2. In the same file, find the Actions column cell renderer in the `columns` `useMemo`
   where `const handleEdit = () => handleRuleEdit(original);` is defined, with `original`
   coming from the row data (semantically an `RLSObject`).
   
   3. Use a TypeScript-aware editor (or language server) to hover over `handleRuleEdit` at
   its definition and at the call site; observe that its signature only accepts `null`,
   despite being invoked with real rule objects.
   
   4. Note that this incorrect signature prevents TypeScript from expressing or checking the
   actual parameter type, undermining type safety and tooling (e.g., no proper autocompletion
   or refactor support for the `rule` argument).
   ```
   </details>
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/pages/RowLevelSecurityList/index.tsx
   **Line:** 77:77
   **Comment:**
   	*Type Error: The `handleRuleEdit` callback parameter is typed as `null`, yet it is called with actual rule objects in the code. This incorrect type annotation misleads the type system and can cause TypeScript compile-time errors or loss of type safety when using the function, since valid RLS rule objects do not conform to the declared type.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37897&comment_hash=685c6bccbcddaefa2b9ab933b1c2c564f81d59a312e0b68f119ebb7e57a5455f&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37897&comment_hash=685c6bccbcddaefa2b9ab933b1c2c564f81d59a312e0b68f119ebb7e57a5455f&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3923596975

   🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/22160058509) for [932fcbf](https://github.com/apache/superset/commit/932fcbf)
   
   • **Environment:** http://34.223.232.161:8080 (admin/admin)
   • **Lifetime:** 48h auto-cleanup
   • **Updates:** New commits create fresh environments automatically


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #37897:
URL: https://github.com/apache/superset/pull/37897#issuecomment-3923703129

   same with the theme page
   <img width="1267" height="413" alt="Screenshot 2026-02-18 at 3 15 55 PM" src="https://github.com/user-attachments/assets/b24923b2-230f-4b37-a810-37d25a57a11b" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(crud): reorder table actions + improve react memoization + improve hooks [superset]

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho merged PR #37897:
URL: https://github.com/apache/superset/pull/37897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org