You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Doychin Bondzhev <do...@dsoft-bg.com> on 2019/01/18 17:41:09 UTC
Looking for review on PR
Hi guys,
Can some one take a look at following PR's?
Startup and shutdown fixes - TOMEE-2454
<https://github.com/apache/tomee/pull/371>
increase the time to wait for sweeps.
<https://github.com/apache/tomee/pull/363>
Make observers more CDI like. This will make the commented test to work.
<https://github.com/apache/tomee/pull/362>
Issue is closed and TomEE uses more recent version
<https://github.com/apache/tomee/pull/361>
Cleanup test code and also minor changes in the tested class.
<https://github.com/apache/tomee/pull/360>
thanks
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116
Re: Looking for review on PR
Posted by Bruno Baptista <br...@gmail.com>.
Hi Doychin,
The test passes but I don't know if the changes are subverting the
original purpose of the test.
Let's wait for some more feedback on that.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 23/01/19 09:34, Doychin Bondzhev wrote:
> I've added new commit to PR
> https://github.com/apache/tomee/pull/360
>
>
> On 21.1.2019 г. 18:14, brunobat [via TomEE & OpenEJB] wrote:
>> Sure Doychin,
>>
>> Looking forward for that update.
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 21/01/19 15:10, Doychin Bondzhev wrote:
>>
>> > Hi Bruno,
>> >
>> > I think I found why AutoConnectionTrackerTest fails.
>> >
>> > In some cases GC is not fast enough to place leaked references into
>> > ReferenceQueue. When setEnvironment is called right after GC there is
>> > a small chance that some references did not manage to get to
>> > referenceQueue on time for the check that queue is empty. In order to
>> > test that theory I added small delay and second poll to the queue and
>> > suddenly I got reference.
>> >
>> > I will update my PR about AutoConnectionTracker and
>> > AutoConnectionTrackerTest with new changes.
>> >
>> > If you don't like the way I did the delay I'm open to suggestions.
>> >
>> > Have a nice day.
>> >
>> > On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:
>> >> Hi Doychin,
>> >>
>> >> I've run all the tests on the merge of the 5 PRs.
>> >>
>> >> I encountered 2 errors. They might be transient ones. Can you please
>> >> take a look?
>> >>
>> >>
>> >> arquillian-tomee-jms-tests
>> >> [ERROR] EnvEntryTest.test:105 » EJB The bean encountered a
>> >> non-application exception; ...
>> >>
>> >> openejb-core
>> >> [ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
>> >> abandoned connection expected:<1> but was:<0>
>> >>
>> >>
>> >> Cheers
>> >>
>> >> Bruno Baptista
>> >> https://twitter.com/brunobat_
>> >>
>> >>
>> >> On 18/01/19 18:32, Bruno Baptista wrote:
>> >>
>> >> >
>> >> > Hi Doychin,
>> >> >
>> >> > Thanks for the contribution!
>> >> >
>> >> > I've approved a couple and left comments in 2 others.
>> >> >
>> >> > Will run all the tests when I get home.
>> >> >
>> >> > Cheers
>> >> >
>> >> > Bruno Baptista
>> >> > https://twitter.com/brunobat_
>> >> >
>> >> >
>> >> > On 18/01/19 17:46, Bruno Baptista wrote:
>> >> >>
>> >> >> Hi Doychin,
>> >> >>
>> >> >> I'll have a look.
>> >> >>
>> >> >> Cheers
>> >> >>
>> >> >> Bruno Baptista
>> >> >> https://twitter.com/brunobat_
>> >> >>
>> >> >>
>> >> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
>> >> >>>
>> >> >>> Hi guys,
>> >> >>>
>> >> >>> Can some one take a look at following PR's?
>> >> >>>
>> >> >>> Startup and shutdown fixes - TOMEE-2454
>> >> >>> <https://github.com/apache/tomee/pull/371>
>> >> >>> increase the time to wait for sweeps.
>> >> >>> <https://github.com/apache/tomee/pull/363>
>> >> >>> Make observers more CDI like. This will make the commented
>> test to
>> >> >>> work. <https://github.com/apache/tomee/pull/362>
>> >> >>> Issue is closed and TomEE uses more recent version
>> >> >>> <https://github.com/apache/tomee/pull/361>
>> >> >>> Cleanup test code and also minor changes in the tested class.
>> >> >>> <https://github.com/apache/tomee/pull/360>
>> >> >>>
>> >> >>> thanks
>> >> >>> --
>> >> >>> Doychin Bondzhev
>> >> >>> dSoft-Bulgaria Ltd.
>> >> >>> PowerPro - billing & provisioning solution for Service providers
>> >> >>> http://www.dsoft-bg.com/
>> >> >>> Mobile: +359888243116
>> >>
>> >>
>> >>
>> ------------------------------------------------------------------------
>> >> If you reply to this email, your message will be added to the
>> >> discussion below:
>> >>
>> http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html
>>
>> >>
>> >> To start a new topic under TomEE Dev, email
>> >> [hidden email] </user/SendEmail.jtp?type=node&node=4687604&i=0>
>> >> To unsubscribe from TomEE Dev, click here
>> >> <
>> >> NAML
>> >>
>> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>
>> >>
>> >
>> >
>> > --
>> > Doychin Bondzhev
>> > dSoft-Bulgaria Ltd.
>> > PowerPro - billing & provisioning solution for Service providers
>> > http://www.dsoft-bg.com/
>> > Mobile: +359888243116
>>
>>
>> ------------------------------------------------------------------------
>> If you reply to this email, your message will be added to the
>> discussion below:
>> http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687604.html
>>
>> To start a new topic under TomEE Dev, email
>> ml+s979440n982480h80@n4.nabble.com
>> To unsubscribe from TomEE Dev, click here
>> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=982480&code=ZG95Y2hpbkBkc29mdC1iZy5jb218OTgyNDgwfC0xNTI2MjM5MTA3>.
>> NAML
>> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>
>
>
> --
> Doychin Bondzhev
> dSoft-Bulgaria Ltd.
> PowerPro - billing & provisioning solution for Service providers
> http://www.dsoft-bg.com/
> Mobile: +359888243116
Re: Looking for review on PR
Posted by Doychin Bondzhev <do...@dsoft-bg.com>.
I've added new commit to PR
https://github.com/apache/tomee/pull/360
On 21.1.2019 г. 18:14, brunobat [via TomEE & OpenEJB] wrote:
> Sure Doychin,
>
> Looking forward for that update.
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 21/01/19 15:10, Doychin Bondzhev wrote:
>
> > Hi Bruno,
> >
> > I think I found why AutoConnectionTrackerTest fails.
> >
> > In some cases GC is not fast enough to place leaked references into
> > ReferenceQueue. When setEnvironment is called right after GC there is
> > a small chance that some references did not manage to get to
> > referenceQueue on time for the check that queue is empty. In order to
> > test that theory I added small delay and second poll to the queue and
> > suddenly I got reference.
> >
> > I will update my PR about AutoConnectionTracker and
> > AutoConnectionTrackerTest with new changes.
> >
> > If you don't like the way I did the delay I'm open to suggestions.
> >
> > Have a nice day.
> >
> > On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:
> >> Hi Doychin,
> >>
> >> I've run all the tests on the merge of the 5 PRs.
> >>
> >> I encountered 2 errors. They might be transient ones. Can you please
> >> take a look?
> >>
> >>
> >> arquillian-tomee-jms-tests
> >> [ERROR] EnvEntryTest.test:105 » EJB The bean encountered a
> >> non-application exception; ...
> >>
> >> openejb-core
> >> [ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
> >> abandoned connection expected:<1> but was:<0>
> >>
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 18/01/19 18:32, Bruno Baptista wrote:
> >>
> >> >
> >> > Hi Doychin,
> >> >
> >> > Thanks for the contribution!
> >> >
> >> > I've approved a couple and left comments in 2 others.
> >> >
> >> > Will run all the tests when I get home.
> >> >
> >> > Cheers
> >> >
> >> > Bruno Baptista
> >> > https://twitter.com/brunobat_
> >> >
> >> >
> >> > On 18/01/19 17:46, Bruno Baptista wrote:
> >> >>
> >> >> Hi Doychin,
> >> >>
> >> >> I'll have a look.
> >> >>
> >> >> Cheers
> >> >>
> >> >> Bruno Baptista
> >> >> https://twitter.com/brunobat_
> >> >>
> >> >>
> >> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
> >> >>>
> >> >>> Hi guys,
> >> >>>
> >> >>> Can some one take a look at following PR's?
> >> >>>
> >> >>> Startup and shutdown fixes - TOMEE-2454
> >> >>> <https://github.com/apache/tomee/pull/371>
> >> >>> increase the time to wait for sweeps.
> >> >>> <https://github.com/apache/tomee/pull/363>
> >> >>> Make observers more CDI like. This will make the commented test to
> >> >>> work. <https://github.com/apache/tomee/pull/362>
> >> >>> Issue is closed and TomEE uses more recent version
> >> >>> <https://github.com/apache/tomee/pull/361>
> >> >>> Cleanup test code and also minor changes in the tested class.
> >> >>> <https://github.com/apache/tomee/pull/360>
> >> >>>
> >> >>> thanks
> >> >>> --
> >> >>> Doychin Bondzhev
> >> >>> dSoft-Bulgaria Ltd.
> >> >>> PowerPro - billing & provisioning solution for Service providers
> >> >>> http://www.dsoft-bg.com/
> >> >>> Mobile: +359888243116
> >>
> >>
> >>
> ------------------------------------------------------------------------
> >> If you reply to this email, your message will be added to the
> >> discussion below:
> >>
> http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html
>
> >>
> >> To start a new topic under TomEE Dev, email
> >> [hidden email] </user/SendEmail.jtp?type=node&node=4687604&i=0>
> >> To unsubscribe from TomEE Dev, click here
> >> <
> >> NAML
> >>
> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
> >>
> >
> >
> > --
> > Doychin Bondzhev
> > dSoft-Bulgaria Ltd.
> > PowerPro - billing & provisioning solution for Service providers
> > http://www.dsoft-bg.com/
> > Mobile: +359888243116
>
>
> ------------------------------------------------------------------------
> If you reply to this email, your message will be added to the
> discussion below:
> http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687604.html
>
> To start a new topic under TomEE Dev, email
> ml+s979440n982480h80@n4.nabble.com
> To unsubscribe from TomEE Dev, click here
> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=982480&code=ZG95Y2hpbkBkc29mdC1iZy5jb218OTgyNDgwfC0xNTI2MjM5MTA3>.
> NAML
> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116
Re: Looking for review on PR
Posted by Bruno Baptista <br...@gmail.com>.
Sure Doychin,
Looking forward for that update.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 21/01/19 15:10, Doychin Bondzhev wrote:
> Hi Bruno,
>
> I think I found why AutoConnectionTrackerTest fails.
>
> In some cases GC is not fast enough to place leaked references into
> ReferenceQueue. When setEnvironment is called right after GC there is
> a small chance that some references did not manage to get to
> referenceQueue on time for the check that queue is empty. In order to
> test that theory I added small delay and second poll to the queue and
> suddenly I got reference.
>
> I will update my PR about AutoConnectionTracker and
> AutoConnectionTrackerTest with new changes.
>
> If you don't like the way I did the delay I'm open to suggestions.
>
> Have a nice day.
>
> On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:
>> Hi Doychin,
>>
>> I've run all the tests on the merge of the 5 PRs.
>>
>> I encountered 2 errors. They might be transient ones. Can you please
>> take a look?
>>
>>
>> arquillian-tomee-jms-tests
>> [ERROR] EnvEntryTest.test:105 » EJB The bean encountered a
>> non-application exception; ...
>>
>> openejb-core
>> [ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
>> abandoned connection expected:<1> but was:<0>
>>
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 18/01/19 18:32, Bruno Baptista wrote:
>>
>> >
>> > Hi Doychin,
>> >
>> > Thanks for the contribution!
>> >
>> > I've approved a couple and left comments in 2 others.
>> >
>> > Will run all the tests when I get home.
>> >
>> > Cheers
>> >
>> > Bruno Baptista
>> > https://twitter.com/brunobat_
>> >
>> >
>> > On 18/01/19 17:46, Bruno Baptista wrote:
>> >>
>> >> Hi Doychin,
>> >>
>> >> I'll have a look.
>> >>
>> >> Cheers
>> >>
>> >> Bruno Baptista
>> >> https://twitter.com/brunobat_
>> >>
>> >>
>> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
>> >>>
>> >>> Hi guys,
>> >>>
>> >>> Can some one take a look at following PR's?
>> >>>
>> >>> Startup and shutdown fixes - TOMEE-2454
>> >>> <https://github.com/apache/tomee/pull/371>
>> >>> increase the time to wait for sweeps.
>> >>> <https://github.com/apache/tomee/pull/363>
>> >>> Make observers more CDI like. This will make the commented test to
>> >>> work. <https://github.com/apache/tomee/pull/362>
>> >>> Issue is closed and TomEE uses more recent version
>> >>> <https://github.com/apache/tomee/pull/361>
>> >>> Cleanup test code and also minor changes in the tested class.
>> >>> <https://github.com/apache/tomee/pull/360>
>> >>>
>> >>> thanks
>> >>> --
>> >>> Doychin Bondzhev
>> >>> dSoft-Bulgaria Ltd.
>> >>> PowerPro - billing & provisioning solution for Service providers
>> >>> http://www.dsoft-bg.com/
>> >>> Mobile: +359888243116
>>
>>
>> ------------------------------------------------------------------------
>> If you reply to this email, your message will be added to the
>> discussion below:
>> http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html
>>
>> To start a new topic under TomEE Dev, email
>> ml+s979440n982480h80@n4.nabble.com
>> To unsubscribe from TomEE Dev, click here
>> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=982480&code=ZG95Y2hpbkBkc29mdC1iZy5jb218OTgyNDgwfC0xNTI2MjM5MTA3>.
>> NAML
>> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>>
>
>
> --
> Doychin Bondzhev
> dSoft-Bulgaria Ltd.
> PowerPro - billing & provisioning solution for Service providers
> http://www.dsoft-bg.com/
> Mobile: +359888243116
Re: Looking for review on PR
Posted by Doychin Bondzhev <do...@dsoft-bg.com>.
Hi Bruno,
I think I found why AutoConnectionTrackerTest fails.
In some cases GC is not fast enough to place leaked references into
ReferenceQueue. When setEnvironment is called right after GC there is a
small chance that some references did not manage to get to
referenceQueue on time for the check that queue is empty. In order to
test that theory I added small delay and second poll to the queue and
suddenly I got reference.
I will update my PR about AutoConnectionTracker and
AutoConnectionTrackerTest with new changes.
If you don't like the way I did the delay I'm open to suggestions.
Have a nice day.
On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:
> Hi Doychin,
>
> I've run all the tests on the merge of the 5 PRs.
>
> I encountered 2 errors. They might be transient ones. Can you please
> take a look?
>
>
> arquillian-tomee-jms-tests
> [ERROR] EnvEntryTest.test:105 » EJB The bean encountered a
> non-application exception; ...
>
> openejb-core
> [ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
> abandoned connection expected:<1> but was:<0>
>
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 18/01/19 18:32, Bruno Baptista wrote:
>
> >
> > Hi Doychin,
> >
> > Thanks for the contribution!
> >
> > I've approved a couple and left comments in 2 others.
> >
> > Will run all the tests when I get home.
> >
> > Cheers
> >
> > Bruno Baptista
> > https://twitter.com/brunobat_
> >
> >
> > On 18/01/19 17:46, Bruno Baptista wrote:
> >>
> >> Hi Doychin,
> >>
> >> I'll have a look.
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
> >>>
> >>> Hi guys,
> >>>
> >>> Can some one take a look at following PR's?
> >>>
> >>> Startup and shutdown fixes - TOMEE-2454
> >>> <https://github.com/apache/tomee/pull/371>
> >>> increase the time to wait for sweeps.
> >>> <https://github.com/apache/tomee/pull/363>
> >>> Make observers more CDI like. This will make the commented test to
> >>> work. <https://github.com/apache/tomee/pull/362>
> >>> Issue is closed and TomEE uses more recent version
> >>> <https://github.com/apache/tomee/pull/361>
> >>> Cleanup test code and also minor changes in the tested class.
> >>> <https://github.com/apache/tomee/pull/360>
> >>>
> >>> thanks
> >>> --
> >>> Doychin Bondzhev
> >>> dSoft-Bulgaria Ltd.
> >>> PowerPro - billing & provisioning solution for Service providers
> >>> http://www.dsoft-bg.com/
> >>> Mobile: +359888243116
>
>
> ------------------------------------------------------------------------
> If you reply to this email, your message will be added to the
> discussion below:
> http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html
>
> To start a new topic under TomEE Dev, email
> ml+s979440n982480h80@n4.nabble.com
> To unsubscribe from TomEE Dev, click here
> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=982480&code=ZG95Y2hpbkBkc29mdC1iZy5jb218OTgyNDgwfC0xNTI2MjM5MTA3>.
> NAML
> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116
Re: Looking for review on PR
Posted by Doychin Bondzhev <do...@dsoft-bg.com>.
Hi Bruon,
Can you send me more from the log regarding EnvEntryTest?
The failure is not related to the application and I have some suspicion
that problem is not related to the test or the code it tests.
From build bot error log I found that after failure of the test,
arquilian undeploys test.ear instead of jms-env-entry.jar
Can you check is that the situation when you run?
Where you run these tests? I tried to run them on Linux and everything
was fine ;-(
On 20.1.2019 �. 14:13, brunobat [via TomEE & OpenEJB] wrote:
> Hi Doychin,
>
> I've run all the tests on the merge of the 5 PRs.
>
> I encountered 2 errors. They might be transient ones. Can you please
> take a look?
>
>
> arquillian-tomee-jms-tests
> [ERROR]�� EnvEntryTest.test:105 � EJB The bean encountered a
> non-application exception; ...
>
> openejb-core
> [ERROR]�� AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
> abandoned connection expected:<1> but was:<0>
>
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 18/01/19 18:32, Bruno Baptista wrote:
>
> >
> > Hi Doychin,
> >
> > Thanks for the contribution!
> >
> > I've approved a couple and left comments in 2 others.
> >
> > Will run all the tests when I get home.
> >
> > Cheers
> >
> > Bruno Baptista
> > https://twitter.com/brunobat_
> >
> >
> > On 18/01/19 17:46, Bruno Baptista wrote:
> >>
> >> Hi Doychin,
> >>
> >> I'll have a look.
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
> >>>
> >>> Hi guys,
> >>>
> >>> Can some one take a look at following PR's?
> >>>
> >>> Startup and shutdown fixes - TOMEE-2454
> >>> <https://github.com/apache/tomee/pull/371>
> >>> increase the time to wait for sweeps.
> >>> <https://github.com/apache/tomee/pull/363>
> >>> Make observers more CDI like. This will make the commented test to
> >>> work. <https://github.com/apache/tomee/pull/362>
> >>> Issue is closed and TomEE uses more recent version
> >>> <https://github.com/apache/tomee/pull/361>
> >>> Cleanup test code and also minor changes in the tested class.
> >>> <https://github.com/apache/tomee/pull/360>
> >>>
> >>> thanks
> >>> --
> >>> Doychin Bondzhev
> >>> dSoft-Bulgaria Ltd.
> >>> PowerPro - billing & provisioning solution for Service providers
> >>> http://www.dsoft-bg.com/
> >>> Mobile: +359888243116
>
>
> ------------------------------------------------------------------------
> If you reply to this email, your message will be added to the
> discussion below:
> http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html
>
> To start a new topic under TomEE Dev, email
> ml+s979440n982480h80@n4.nabble.com
> To unsubscribe from TomEE Dev, click here
> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=982480&code=ZG95Y2hpbkBkc29mdC1iZy5jb218OTgyNDgwfC0xNTI2MjM5MTA3>.
> NAML
> <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116
Re: Looking for review on PR
Posted by Bruno Baptista <br...@gmail.com>.
Hi Doychin,
I've run all the tests on the merge of the 5 PRs.
I encountered 2 errors. They might be transient ones. Can you please
take a look?
arquillian-tomee-jms-tests
[ERROR] EnvEntryTest.test:105 » EJB The bean encountered a
non-application exception; ...
openejb-core
[ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
abandoned connection expected:<1> but was:<0>
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 18/01/19 18:32, Bruno Baptista wrote:
>
> Hi Doychin,
>
> Thanks for the contribution!
>
> I've approved a couple and left comments in 2 others.
>
> Will run all the tests when I get home.
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 18/01/19 17:46, Bruno Baptista wrote:
>>
>> Hi Doychin,
>>
>> I'll have a look.
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 18/01/19 17:41, Doychin Bondzhev wrote:
>>>
>>> Hi guys,
>>>
>>> Can some one take a look at following PR's?
>>>
>>> Startup and shutdown fixes - TOMEE-2454
>>> <https://github.com/apache/tomee/pull/371>
>>> increase the time to wait for sweeps.
>>> <https://github.com/apache/tomee/pull/363>
>>> Make observers more CDI like. This will make the commented test to
>>> work. <https://github.com/apache/tomee/pull/362>
>>> Issue is closed and TomEE uses more recent version
>>> <https://github.com/apache/tomee/pull/361>
>>> Cleanup test code and also minor changes in the tested class.
>>> <https://github.com/apache/tomee/pull/360>
>>>
>>> thanks
>>> --
>>> Doychin Bondzhev
>>> dSoft-Bulgaria Ltd.
>>> PowerPro - billing & provisioning solution for Service providers
>>> http://www.dsoft-bg.com/
>>> Mobile: +359888243116
Re: Looking for review on PR
Posted by Bruno Baptista <br...@gmail.com>.
Hi Doychin,
Thanks for the contribution!
I've approved a couple and left comments in 2 others.
Will run all the tests when I get home.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 18/01/19 17:46, Bruno Baptista wrote:
>
> Hi Doychin,
>
> I'll have a look.
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 18/01/19 17:41, Doychin Bondzhev wrote:
>>
>> Hi guys,
>>
>> Can some one take a look at following PR's?
>>
>> Startup and shutdown fixes - TOMEE-2454
>> <https://github.com/apache/tomee/pull/371>
>> increase the time to wait for sweeps.
>> <https://github.com/apache/tomee/pull/363>
>> Make observers more CDI like. This will make the commented test to
>> work. <https://github.com/apache/tomee/pull/362>
>> Issue is closed and TomEE uses more recent version
>> <https://github.com/apache/tomee/pull/361>
>> Cleanup test code and also minor changes in the tested class.
>> <https://github.com/apache/tomee/pull/360>
>>
>> thanks
>> --
>> Doychin Bondzhev
>> dSoft-Bulgaria Ltd.
>> PowerPro - billing & provisioning solution for Service providers
>> http://www.dsoft-bg.com/
>> Mobile: +359888243116
Re: Looking for review on PR
Posted by Bruno Baptista <br...@gmail.com>.
Hi Doychin,
I'll have a look.
Cheers
Bruno Baptista
https://twitter.com/brunobat_
On 18/01/19 17:41, Doychin Bondzhev wrote:
>
> Hi guys,
>
> Can some one take a look at following PR's?
>
> Startup and shutdown fixes - TOMEE-2454
> <https://github.com/apache/tomee/pull/371>
> increase the time to wait for sweeps.
> <https://github.com/apache/tomee/pull/363>
> Make observers more CDI like. This will make the commented test to
> work. <https://github.com/apache/tomee/pull/362>
> Issue is closed and TomEE uses more recent version
> <https://github.com/apache/tomee/pull/361>
> Cleanup test code and also minor changes in the tested class.
> <https://github.com/apache/tomee/pull/360>
>
> thanks
> --
> Doychin Bondzhev
> dSoft-Bulgaria Ltd.
> PowerPro - billing & provisioning solution for Service providers
> http://www.dsoft-bg.com/
> Mobile: +359888243116