[GitHub] [cloudstack] rhtyd commented on a change in pull request #3564: add vSphere 6.7.3 and update 6.7.2 & 6.7.1

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #3564: add vSphere 6.7.3 and update 6.7.2 & 6.7.1
URL: https://github.com/apache/cloudstack/pull/3564#discussion_r315052862
 
 

 ##########
 File path: engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql
 ##########
 @@ -27,6 +27,9 @@ INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, hypervisor_type, hype
 
 -- Add VMware 6.7 hypervisor capabilities
 INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid,hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) VALUES (UUID(), 'VMware', '6.7', '1024', '0', '59', '64', '1', '1');
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid,hypervisor_type, hypervisor_version, max_guests_limit, security_group_enabled, max_data_volumes_limit, max_hosts_per_cluster, storage_motion_supported, vm_snapshot_enabled) VALUES (UUID(), 'VMware', '6.7.1', '1024', '0', '59', '64', '1', '1');
 
 Review comment:
   @PaulAngus have you tested if adding the minor version makes any difference? That is will a 6.7.1/6.7.2/6.7.3 be still recognised by CloudStack as 6.7?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services