You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2016/05/07 04:44:09 UTC
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/12973
[SPARK-12377][PySpark] Missing argments in implementation for Row.__call__ in PySpark
## What changes were proposed in this pull request?
This PR corrects the implementation of `Row.__call__` so that let the object acts like class.
## How was this patch tested?
Unittests in `pyspark/sql/types.py`.
Closes #10356
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark pr/10356
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12973
----
commit bbc38ba690bed3ba777817b0dda15b51cbd031f2
Author: somideshmukh <so...@us.ibm.com>
Date: 2015-12-17T09:48:54Z
[SPARK-12377][Python][Wrong implementation for Row.__call__ in pyspark]
commit 2b3e9b91a6d8a887998c556a5c30e1385efe6089
Author: somideshmukh <so...@us.ibm.com>
Date: 2016-01-14T12:02:04Z
[SPARK-12377][Python][Wrong implementation for Row.__call__ in pyspark,Added Regression Testing]
commit 18108fa7a5494eafd802fd685204d429b1549aae
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-05-07T03:15:22Z
Fetch upstream
commit cf1fd05c681de68db159968622cb379c4718f197
Author: hyukjinkwon <gu...@gmail.com>
Date: 2016-05-07T04:40:25Z
Object-like access of PySpark
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12377][PySpark] Missing argments i...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/12973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12377][PySpark] Missing argments i...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217608050
**[Test build #58058 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58058/consoleFull)** for PR 12973 at commit [`378f195`](https://github.com/apache/spark/commit/378f19588e6cc12d454c5b9eb1a24ae0b169d0e9).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217606626
**[Test build #58057 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58057/consoleFull)** for PR 12973 at commit [`cf1fd05`](https://github.com/apache/spark/commit/cf1fd05c681de68db159968622cb379c4718f197).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217607328
**[Test build #58058 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58058/consoleFull)** for PR 12973 at commit [`378f195`](https://github.com/apache/spark/commit/378f19588e6cc12d454c5b9eb1a24ae0b169d0e9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12377][PySpark] Missing argments i...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217608440
Oh I see. The usage was as below and it seems the correct behaviour
```
row = Row("f1", "f2")
>>> row(1, 2)
Row(f1=1, f2=2)
```
Sorry, closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217606585
I submitted this PR because the author is not answering (for about four months). If the author answers or this PR is problematic, I am happy to close this.
@JoshRosen Could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217607853
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12377][PySpark] Missing argments i...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217608052
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58058/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217607848
**[Test build #58057 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58057/consoleFull)** for PR 12973 at commit [`cf1fd05`](https://github.com/apache/spark/commit/cf1fd05c681de68db159968622cb379c4718f197).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217606617
I submitted this PR because the author is not answering (for about four months). If the author answers or this PR is problematic, I am happy to close this.
@JoshRosen Could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [WIP][SPARK-12377][PySpark] Missing argments i...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217608051
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12377][PySpark] Missing argments in imp...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12973#issuecomment-217607854
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58057/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org