You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Yi Liu (JIRA)" <ji...@apache.org> on 2014/08/19 09:51:18 UTC

[jira] [Created] (HDFS-6870) Blocks and INodes could leak for Rename with overwrite flag

Yi Liu created HDFS-6870:
----------------------------

             Summary: Blocks and INodes could leak for Rename with overwrite flag
                 Key: HDFS-6870
                 URL: https://issues.apache.org/jira/browse/HDFS-6870
             Project: Hadoop HDFS
          Issue Type: Bug
            Reporter: Yi Liu
            Assignee: Yi Liu


Following code in FSDirectory#unprotectedRenameTo doesn't collect blocks and INodes for non snapshot path.
{code}
if (removedDst != null) {
          undoRemoveDst = false;
          if (removedNum > 0) {
            BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
            List<INode> removedINodes = new ChunkedArrayList<INode>();
            filesDeleted = removedDst.cleanSubtree(Snapshot.CURRENT_STATE_ID,
                dstIIP.getLatestSnapshotId(), collectedBlocks, removedINodes,
                true).get(Quota.NAMESPACE);
            getFSNamesystem().removePathAndBlocks(src, collectedBlocks,
                removedINodes, false);
          }
        }
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)