[GitHub] [iceberg] rdblue commented on a diff in pull request #6460: Core: Refactor ManifestListReadTask to avoid extra S3 calls

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6460:
URL: https://github.com/apache/iceberg/pull/6460#discussion_r1053447615


##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -168,31 +153,34 @@ static class ManifestListReadTask implements DataTask {
     private final FileIO io;
     private final Schema schema;
     private final Map<Integer, PartitionSpec> specs;
-    private final FileScanTask manifestListTask;
+    private final String manifestListLocation;
+    private final Expression residual;
     private final long referenceSnapshotId;
 
     ManifestListReadTask(
         FileIO io,
         Schema schema,
         Map<Integer, PartitionSpec> specs,
-        FileScanTask manifestListTask,
+        String manifestListLocation,
+        Expression residual,
         long referenceSnapshotId) {
       this.io = io;
       this.schema = schema;
       this.specs = specs;
-      this.manifestListTask = manifestListTask;
+      this.manifestListLocation = manifestListLocation;
+      this.residual = residual;
       this.referenceSnapshotId = referenceSnapshotId;
     }
 
     @Override
     public List<DeleteFile> deletes() {
-      return manifestListTask.deletes();
+      return ImmutableList.of();

Review Comment:
   That's right. We don't have delete files against manifests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org