svn commit: r666680 - /ode/branches/APACHE_ODE_1.1/bpel-runtime/src/main/java/org/apache/ode/bpel/runtime/PICK.java

[mr...@apache.org]

Author: mriou
Date: Wed Jun 11 07:26:05 2008
New Revision: 666680

URL: http://svn.apache.org/viewvc?rev=666680&view=rev
Log:
Slightly better error reporting on wrong message exchange status for receives (usually people just didn't put a reply at the right place).

Modified:
    ode/branches/APACHE_ODE_1.1/bpel-runtime/src/main/java/org/apache/ode/bpel/runtime/PICK.java

Modified: ode/branches/APACHE_ODE_1.1/bpel-runtime/src/main/java/org/apache/ode/bpel/runtime/PICK.java
URL: http://svn.apache.org/viewvc/ode/branches/APACHE_ODE_1.1/bpel-runtime/src/main/java/org/apache/ode/bpel/runtime/PICK.java?rev=666680&r1=666679&r2=666680&view=diff
==============================================================================
--- ode/branches/APACHE_ODE_1.1/bpel-runtime/src/main/java/org/apache/ode/bpel/runtime/PICK.java (original)
+++ ode/branches/APACHE_ODE_1.1/bpel-runtime/src/main/java/org/apache/ode/bpel/runtime/PICK.java Wed Jun 11 07:26:05 2008
@@ -157,7 +157,18 @@
         // This is allowed, if there is no parts in the message for example.
         if (onMessage.variable == null) return;
 
-        Element msgEl = getBpelRuntimeContext().getMyRequest(mexId);
+        Element msgEl;
+        try {
+            // At this point, not being able to get the request is most probably
+            // a mex that hasn't properly replied to (process issue).
+            msgEl = getBpelRuntimeContext().getMyRequest(mexId);
+        } catch (ExternalVariableModuleException e) {
+            __log.error("The message exchange seems to be in an unconsistent state, you're " +
+                "probably missing a reply on a request/response interaction.");
+            _self.parent.failure(e.toString(), null);
+            return;
+        }
+
         Collection<String> partNames = (Collection<String>) onMessage.operation.getInput().getMessage().getParts().keySet();
 
         // Let's do some sanity checks here so that we don't get weird errors in assignment later.