You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/13 18:20:31 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #11111: ARROW-13882: [C++] Improve min_max/hash_min_max type support

lidavidm commented on a change in pull request #11111:
URL: https://github.com/apache/arrow/pull/11111#discussion_r707576152



##########
File path: cpp/src/arrow/array/validate.cc
##########
@@ -498,6 +498,11 @@ struct ValidateArrayFullImpl {
 
   Status Visit(const StructType& type) {
     // Validate children
+    if (data.child_data.size() != static_cast<size_t>(type.num_fields())) {

Review comment:
       Hmm. Odd, I do remember getting a crash for this reason here. But there is indeed a check: https://github.com/apache/arrow/blob/87b2fcd53bfd7ed4fcb5c4d98fd4f4f4f4aac158/cpp/src/arrow/array/validate.cc#L367-L374




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org