You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/19 06:47:54 UTC

[GitHub] [skywalking-rocketbot-ui] heihaozi opened a new pull request #478: When creating service groups in the topology, it is better if the service names are sorted. 

heihaozi opened a new pull request #478:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/478


   Fix #477 
   
   Before fix:
   
   ![20210419143156](https://user-images.githubusercontent.com/2956927/115192950-1ba7ba80-a11e-11eb-8be2-81064e832273.jpg)
   
   After fix:
   
   ![20210419143422](https://user-images.githubusercontent.com/2956927/115192973-22cec880-a11e-11eb-94ff-775ac4581315.jpg)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] heihaozi commented on a change in pull request #478: When creating service groups in the topology, it is better if the service names are sorted.

Posted by GitBox <gi...@apache.org>.
heihaozi commented on a change in pull request #478:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/478#discussion_r615715593



##########
File path: src/views/components/topology/topo-group/index.vue
##########
@@ -98,7 +98,10 @@ limitations under the License. -->
           duration: this.durationTime,
         },
       }).then((res: AxiosResponse) => {
-        this.servicesMap = res.data.data.services ? res.data.data.services : [];
+        const map = res.data.data.services ? res.data.data.services : [];
+        this.servicesMap = map.sort((a: any, b: any) => {

Review comment:
       This is a good idea, I will revise it right away. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #478: When creating service groups in the topology, it is better if the service names are sorted.

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #478:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/478#discussion_r615597952



##########
File path: src/views/components/topology/topo-group/index.vue
##########
@@ -98,7 +98,10 @@ limitations under the License. -->
           duration: this.durationTime,
         },
       }).then((res: AxiosResponse) => {
-        this.servicesMap = res.data.data.services ? res.data.data.services : [];
+        const map = res.data.data.services ? res.data.data.services : [];
+        this.servicesMap = map.sort((a: any, b: any) => {

Review comment:
       Please Set types for `a` and `b`.  Here they are. `import { Option } from '@/types/global';`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #478: When creating service groups in the topology, it is better if the service names are sorted.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #478:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/478#issuecomment-822329716


   @Fine0830 Check the codes, please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #478: When creating service groups in the topology, it is better if the service names are sorted.

Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #478:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/478


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org