You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/03/27 03:45:56 UTC
[GitHub] [incubator-uniffle] turboFei opened a new pull request, #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
turboFei opened a new pull request, #766:
URL: https://github.com/apache/incubator-uniffle/pull/766
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#issuecomment-1485092211
Great work! Thank you very much for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] turboFei commented on a diff in pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#discussion_r1203319621
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -36,4 +40,27 @@ public static void closeQuietly(Closeable closeable) {
logger.error("IOException should not have been thrown.", e);
}
}
+
+ public static <K, V> ConcurrentHashMap<K, V> newConcurrentMap() {
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ return new ConcurrentHashMap();
+ } else {
+ return new ConcurrentHashMapForJDK8();
+ }
+ }
+
+ /**
+ * For JDK8, there is bug for ConcurrentHashMap#computeIfAbsent, checking the key existence to
+ * speed up. See details in issue #519
+ */
+ private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
+ @Override
+ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+ V result;
+ if (null == (result = get(key))) {
Review Comment:
for the original impl, it can not finish in 10 minutes, so I interrupt it.
Just like the class name, `DeadLockMain`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston merged pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] turboFei commented on a diff in pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#discussion_r1150278831
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -36,4 +40,27 @@ public static void closeQuietly(Closeable closeable) {
logger.error("IOException should not have been thrown.", e);
}
}
+
+ public static <K, V> ConcurrentHashMap<K, V> newConcurrentMap() {
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ return new ConcurrentHashMap();
+ } else {
+ return new ConcurrentHashMapForJDK8();
+ }
+ }
+
+ /**
+ * For JDK8, there is bug for ConcurrentHashMap#computeIfAbsent, checking the key existence to
+ * speed up. See details in issue #519
+ */
+ private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
+ @Override
+ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+ V result;
+ if (null == (result = get(key))) {
Review Comment:
Will try it，thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] turboFei commented on pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#issuecomment-1484596021
cc @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#discussion_r1150190431
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -36,4 +40,27 @@ public static void closeQuietly(Closeable closeable) {
logger.error("IOException should not have been thrown.", e);
}
}
+
+ public static <K, V> ConcurrentHashMap<K, V> newConcurrentMap() {
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ return new ConcurrentHashMap();
+ } else {
+ return new ConcurrentHashMapForJDK8();
+ }
+ }
+
+ /**
+ * For JDK8, there is bug for ConcurrentHashMap#computeIfAbsent, checking the key existence to
+ * speed up. See details in issue #519
+ */
+ private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
+ @Override
+ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+ V result;
+ if (null == (result = get(key))) {
Review Comment:
@turboFei did you run the benchmark tests provided in the [JDK bug report](https://bugs.openjdk.org/browse/JDK-8161372): `DeadLockMain.java`?
Would you mind post a comparison result here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] turboFei commented on a diff in pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#discussion_r1201835734
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -36,4 +40,27 @@ public static void closeQuietly(Closeable closeable) {
logger.error("IOException should not have been thrown.", e);
}
}
+
+ public static <K, V> ConcurrentHashMap<K, V> newConcurrentMap() {
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ return new ConcurrentHashMap();
+ } else {
+ return new ConcurrentHashMapForJDK8();
+ }
+ }
+
+ /**
+ * For JDK8, there is bug for ConcurrentHashMap#computeIfAbsent, checking the key existence to
+ * speed up. See details in issue #519
+ */
+ private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
+ @Override
+ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+ V result;
+ if (null == (result = get(key))) {
Review Comment:
FYI:
```
import java.util.ArrayList;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Function;
public class DeadlockMainV2 {
private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
@Override
public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
V result;
if (null == (result = get(key))) {
result = super.computeIfAbsent(key, mappingFunction);
}
return result;
}
}
static final int MAP_SIZE=20;
static final int THREADS=20;
static final ConcurrentHashMap<Integer,Integer> map = new ConcurrentHashMapForJDK8();
static {
for (int i = 0; i < MAP_SIZE; i++) map.put(i, i);
}
static class TestThread extends Thread {
@Override
public void run() {
int i=0; int result =0;
while(result<Integer.MAX_VALUE) {
i = (i+1) % MAP_SIZE;
result += map.computeIfAbsent(i, (key)->key+key);
}
}
}
public static void main(String[]v) throws InterruptedException {
long startTime = System.currentTimeMillis();
ArrayList<Thread> threads = new ArrayList<>();
for (int i=0;i<THREADS;i++) {
TestThread t = new TestThread();
threads.add(t);
t.start();
}
threads.get(0).join();
long endTime = System.currentTimeMillis();
System.out.println(String.format("Total cost: %d s", (endTime - startTime) / 1000));
}
}
```
output:
<img width="935" alt="image" src="https://github.com/apache/incubator-uniffle/assets/6757692/53d19cf2-aa82-4352-a936-4250c7f1028b">
The result is expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#discussion_r1202191844
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -36,4 +40,27 @@ public static void closeQuietly(Closeable closeable) {
logger.error("IOException should not have been thrown.", e);
}
}
+
+ public static <K, V> ConcurrentHashMap<K, V> newConcurrentMap() {
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ return new ConcurrentHashMap();
+ } else {
+ return new ConcurrentHashMapForJDK8();
+ }
+ }
+
+ /**
+ * For JDK8, there is bug for ConcurrentHashMap#computeIfAbsent, checking the key existence to
+ * speed up. See details in issue #519
+ */
+ private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
+ @Override
+ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+ V result;
+ if (null == (result = get(key))) {
Review Comment:
Thanks. What's the total cost for the original impl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] turboFei commented on a diff in pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#discussion_r1203319621
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -36,4 +40,27 @@ public static void closeQuietly(Closeable closeable) {
logger.error("IOException should not have been thrown.", e);
}
}
+
+ public static <K, V> ConcurrentHashMap<K, V> newConcurrentMap() {
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ return new ConcurrentHashMap();
+ } else {
+ return new ConcurrentHashMapForJDK8();
+ }
+ }
+
+ /**
+ * For JDK8, there is bug for ConcurrentHashMap#computeIfAbsent, checking the key existence to
+ * speed up. See details in issue #519
+ */
+ private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
+ @Override
+ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+ V result;
+ if (null == (result = get(key))) {
Review Comment:
for the original impl, it can not finish in 10 minutes, so I interrupt it.
Just like the class name saied, `DeadLockMain`.
##########
common/src/main/java/org/apache/uniffle/common/util/JavaUtils.java:
##########
@@ -36,4 +40,27 @@ public static void closeQuietly(Closeable closeable) {
logger.error("IOException should not have been thrown.", e);
}
}
+
+ public static <K, V> ConcurrentHashMap<K, V> newConcurrentMap() {
+ if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
+ return new ConcurrentHashMap();
+ } else {
+ return new ConcurrentHashMapForJDK8();
+ }
+ }
+
+ /**
+ * For JDK8, there is bug for ConcurrentHashMap#computeIfAbsent, checking the key existence to
+ * speed up. See details in issue #519
+ */
+ private static class ConcurrentHashMapForJDK8<K, V> extends ConcurrentHashMap<K, V> {
+ @Override
+ public V computeIfAbsent(K key, Function<? super K, ? extends V> mappingFunction) {
+ V result;
+ if (null == (result = get(key))) {
Review Comment:
for the original impl, it can not finish in 10 minutes, so I interrupt it.
Just like the class name sayied, `DeadLockMain`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #766: [#519] Speed up ConcurrentHashMap#computeIfAbsent
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #766:
URL: https://github.com/apache/incubator-uniffle/pull/766#issuecomment-1484449601
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#766](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ec3a20) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/567872b8c89a19c16e31c7919ab196fe7568c02a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (567872b) will **increase** coverage by `2.39%`.
> The diff coverage is `90.32%`.
> :exclamation: Current head 4ec3a20 differs from pull request most recent head eff4784. Consider uploading reports for the commit eff4784 to get more accurate results
```diff
@@ Coverage Diff @@
## master #766 +/- ##
============================================
+ Coverage 60.67% 63.07% +2.39%
- Complexity 1901 1953 +52
============================================
Files 239 230 -9
Lines 13031 11346 -1685
Branches 1091 1119 +28
============================================
- Hits 7907 7156 -751
+ Misses 4686 3792 -894
+ Partials 438 398 -40
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/uniffle/common/util/JavaUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi91dGlsL0phdmFVdGlscy5qYXZh) | `35.71% <16.66%> (-14.29%)` | :arrow_down: |
| [...apache/uniffle/storage/common/AbstractStorage.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2NvbW1vbi9BYnN0cmFjdFN0b3JhZ2UuamF2YQ==) | `51.35% <83.33%> (ø)` | |
| [...g/apache/hadoop/mapred/SortWriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkL1NvcnRXcml0ZUJ1ZmZlck1hbmFnZXIuamF2YQ==) | `79.89% <100.00%> (ø)` | |
| [...he/uniffle/client/impl/ShuffleWriteClientImpl.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVXcml0ZUNsaWVudEltcGwuamF2YQ==) | `33.66% <100.00%> (ø)` | |
| [...org/apache/uniffle/common/metrics/GRPCMetrics.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9tZXRyaWNzL0dSUENNZXRyaWNzLmphdmE=) | `47.88% <100.00%> (ø)` | |
| [...apache/uniffle/coordinator/ApplicationManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQXBwbGljYXRpb25NYW5hZ2VyLmphdmE=) | `83.88% <100.00%> (ø)` | |
| [.../apache/uniffle/coordinator/ClientConfManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ2xpZW50Q29uZk1hbmFnZXIuamF2YQ==) | `92.95% <100.00%> (ø)` | |
| [...a/org/apache/uniffle/coordinator/QuotaManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvUXVvdGFNYW5hZ2VyLmphdmE=) | `84.41% <100.00%> (ø)` | |
| [...ache/uniffle/coordinator/SimpleClusterManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvU2ltcGxlQ2x1c3Rlck1hbmFnZXIuamF2YQ==) | `75.31% <100.00%> (ø)` | |
| [...uniffle/coordinator/metric/CoordinatorMetrics.java](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvbWV0cmljL0Nvb3JkaW5hdG9yTWV0cmljcy5qYXZh) | `94.28% <100.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-uniffle/pull/766?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [27 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/766/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org