You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2017/11/09 14:47:50 UTC
[whimsy] branch master updated: fix tests to match current behavior,
and fix regression identified in the process
This is an automated email from the ASF dual-hosted git repository.
rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 814f0c0 fix tests to match current behavior, and fix regression identified in the process
814f0c0 is described below
commit 814f0c055d5e67bf14b875417ebe2dc0e2dfc40d
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Thu Nov 9 09:47:16 2017 -0500
fix tests to match current behavior, and fix regression identified in the
process
---
www/board/agenda/spec/other_views_spec.rb | 14 +++++++-------
www/board/agenda/views/layout/footer.js.rb | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/www/board/agenda/spec/other_views_spec.rb b/www/board/agenda/spec/other_views_spec.rb
index 7ce38df..d34e0b3 100644
--- a/www/board/agenda/spec/other_views_spec.rb
+++ b/www/board/agenda/spec/other_views_spec.rb
@@ -108,22 +108,22 @@ feature 'other reports' do
text: 'Mesos'
end
- it "should skip to flagged items once meeting has started" do
+ it "should skip to missing/flagged items once meeting has started" do
visit '/2015-02-18/Security-Team'
- expect(page).to have_selector '.nextlink[href="flagged/Axis"]',
- text: 'Axis'
+ expect(page).to have_selector '.nextlink[href="flagged/Abdera"]',
+ text: 'Abdera'
- visit '/2015-02-18/flagged/Axis'
+ visit '/2015-02-18/flagged/Abdera'
expect(page).to have_selector '.backlink[href="Security-Team"]',
text: 'Security Team'
- visit '/2015-02-18/flagged/Lenya'
+ visit '/2015-02-18/flagged/Xerces'
expect(page).to have_selector '.nextlink[href="Change-Geronimo-Chair"]',
text: 'Change Geronimo Chair'
visit '/2015-02-18/Change-Geronimo-Chair'
- expect(page).to have_selector '.backlink[href="flagged/Lenya"]',
- text: 'Lenya'
+ expect(page).to have_selector '.backlink[href="flagged/Xerces"]',
+ text: 'Xerces'
end
it "should highlight and crosslink action items" do
diff --git a/www/board/agenda/views/layout/footer.js.rb b/www/board/agenda/views/layout/footer.js.rb
index 1a8114b..1c76e17 100644
--- a/www/board/agenda/views/layout/footer.js.rb
+++ b/www/board/agenda/views/layout/footer.js.rb
@@ -49,7 +49,7 @@ class Footer < Vue
link and link.attach =~ /^[A-Z]/
then
Agenda.index.each do |item|
- if item.flagged
+ if item.flagged and item.attach =~ /^[A-Z]/
prefix = 'flagged/'
link = item
end
--
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].