You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/27 18:41:09 UTC

[GitHub] [druid] maytasm commented on a change in pull request #11311: Fix bug: 502 bad gateway thrown when we edit/delete any auto compaction config created 0.21.0 or before

maytasm commented on a change in pull request #11311:
URL: https://github.com/apache/druid/pull/11311#discussion_r640878532



##########
File path: core/src/main/java/org/apache/druid/common/config/JacksonConfigManager.java
##########
@@ -90,14 +100,15 @@ public JacksonConfigManager(
    *
    * @param key of the config to set
    * @param oldValue old config value. If not null, then the update will only succeed if the insert
-   *                 happens when current database entry is the same as this value. If null, then the insert
-   *                 will not consider the current database entry.
+   *                 happens when current database entry is the same as this value. Note that the current database
+   *                 entry (in array of bytes) have to be exactly the same as the array of bytes of this value for
+   *                 update to succeed. If null, then the insert will not consider the current database entry.

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org