You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/31 08:19:40 UTC

[GitHub] [hudi] zpi1223 opened a new pull request, #5721: Syntax error: Incorrect use of Commas in English and Chinese

zpi1223 opened a new pull request, #5721:
URL: https://github.com/apache/hudi/pull/5721

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   This pull request is for document syntax errors to change, involving a total of 5 MD documents.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] zpi1223 commented on pull request #5721: [MINOR]: Half-width comma instead full-width comma

Posted by GitBox <gi...@apache.org>.
zpi1223 commented on PR #5721:
URL: https://github.com/apache/hudi/pull/5721#issuecomment-1141943208

   > Thanks for the contribution, usually we follow this rule for the commit message:
   > 
   > 1. If this is a minor change, prefix the commit title : `[minor] ${your commit title}`
   > 2. If this is a major change, you should fire a JIRA issue and make the title as style: `[HUDI-${JIRA_ID}] ${your commit title}`
   
   I see，I've made adjustments. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua merged pull request #5721: [MINOR] Fix incorrect full-width comma usage in the doc DDL demo

Posted by GitBox <gi...@apache.org>.
yanghua merged PR #5721:
URL: https://github.com/apache/hudi/pull/5721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] zpi1223 commented on pull request #5721: [MINOR] Fix incorrect full-width comma usage in the doc DDL demo

Posted by GitBox <gi...@apache.org>.
zpi1223 commented on PR #5721:
URL: https://github.com/apache/hudi/pull/5721#issuecomment-1142042075

   > LGTM @zpi1223 Thanks for your contribution!
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #5721: Syntax error: Incorrect use of Commas in English and Chinese

Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5721:
URL: https://github.com/apache/hudi/pull/5721#issuecomment-1141929355

   Thanks for the contribution, usually we follow this rule for the commit message:
   
   1. If this is a minor change, prefix the commit title : `[minor] ${your commit title}`
   2. If this is a major change, you should fire a JIRA issue and make the title as style: `[HUDI-${JIRA_ID}] ${your commit title}`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org