You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "vy (via GitHub)" <gi...@apache.org> on 2023/11/30 16:00:28 UTC
[PR] Upgrade `2.x` compiler baseline to Java 17 (logging-log4j2)
vy opened a new pull request, #2021:
URL: https://github.com/apache/logging-log4j2/pull/2021
*Warning!* `revision` needs to be adjusted prior to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade `2.x` compiler baseline to Java 17 (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #2021:
URL: https://github.com/apache/logging-log4j2/pull/2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade `2.x` compiler baseline to Java 17 (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #2021:
URL: https://github.com/apache/logging-log4j2/pull/2021#discussion_r1411956760
##########
.github/dependabot.yaml:
##########
@@ -71,15 +62,9 @@ updates:
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- dependency-name: "org.openrewrite.recipe:*"
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- # Json Unit 3.x requires Java 17
- - dependency-name: "net.javacrumbs.json-unit:*"
- versions: ["[3.0.0,)"]
# LMAX Disruptor requires Java 11
- dependency-name: "com.lmax:disruptor"
versions: ["[4.0.0,)"]
- # WebCompere System Stubs requires Java 11
- - dependency-name: "uk.org.webcompere:*"
- versions: ["2.1.0,)"]
Review Comment:
:+1: Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade `2.x` compiler baseline to Java 17 (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #2021:
URL: https://github.com/apache/logging-log4j2/pull/2021#discussion_r1410893104
##########
.github/dependabot.yaml:
##########
@@ -43,21 +43,12 @@ updates:
# Keep Logback version 1.2.x
- dependency-name: "ch.qos.logback:*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
- # Mockito 5.x requires Java 11
- - dependency-name: "org.mockito:*"
- update-types: ["version-update:semver-major"]
- # JUnit Pioneer 2.x requires Java 11
- - dependency-name: "org.junit-pioneer:*"
- update-types: ["version-update:semver-major"]
Review Comment:
Are you sure, we can upgrade these?
These are test dependencies and tests are still compiled with `-release 8` and **must** run on JRE 8.
##########
.github/dependabot.yaml:
##########
@@ -71,15 +62,9 @@ updates:
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- dependency-name: "org.openrewrite.recipe:*"
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- # Json Unit 3.x requires Java 17
- - dependency-name: "net.javacrumbs.json-unit:*"
- versions: ["[3.0.0,)"]
# LMAX Disruptor requires Java 11
- dependency-name: "com.lmax:disruptor"
versions: ["[4.0.0,)"]
- # WebCompere System Stubs requires Java 11
- - dependency-name: "uk.org.webcompere:*"
- versions: ["2.1.0,)"]
Review Comment:
Also must be `< 2.1.0`.
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/DatePatternConverterTestBase.java:
##########
@@ -119,12 +100,17 @@ private String precisePattern(final String pattern, final int precision) {
}
@Test
- public void testFormatDateStringBuilderDefaultPattern() {
+ void testThreadLocalsConstant() {
+ assertEquals(threadLocalsEnabled, Constants.ENABLE_THREADLOCALS);
+ }
+
+ @Test
+ void testFormatDateStringBuilderDefaultPattern() {
assertDatePattern(null, date(2001, 1, 1), "2001-02-01 14:15:16,123");
}
@Test
- public void testFormatDateStringBuilderIso8601() {
+ void testFormatDateStringBuilderIso8601() {
Review Comment:
There is an OpenRewrite recipe for this: [Remove public visibility of JUnit 5 tests](https://docs.openrewrite.org/recipes/java/testing/cleanup/testsshouldnotbepublic).
I would prefer to run this recipe on all our tests in a separate PR (although I am not strict about this).
##########
.github/dependabot.yaml:
##########
@@ -71,15 +62,9 @@ updates:
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- dependency-name: "org.openrewrite.recipe:*"
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- # Json Unit 3.x requires Java 17
- - dependency-name: "net.javacrumbs.json-unit:*"
- versions: ["[3.0.0,)"]
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade `2.x` compiler baseline to Java 17 (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #2021:
URL: https://github.com/apache/logging-log4j2/pull/2021#discussion_r1411956493
##########
.github/dependabot.yaml:
##########
@@ -43,21 +43,12 @@ updates:
# Keep Logback version 1.2.x
- dependency-name: "ch.qos.logback:*"
update-types: ["version-update:semver-major", "version-update:semver-minor"]
- # Mockito 5.x requires Java 11
- - dependency-name: "org.mockito:*"
- update-types: ["version-update:semver-major"]
- # JUnit Pioneer 2.x requires Java 11
- - dependency-name: "org.junit-pioneer:*"
- update-types: ["version-update:semver-major"]
Review Comment:
:+1: Reverted.
##########
.github/dependabot.yaml:
##########
@@ -71,15 +62,9 @@ updates:
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- dependency-name: "org.openrewrite.recipe:*"
update-types: ["version-update:semver-minor", "version-update:semver-patch"]
- # Json Unit 3.x requires Java 17
- - dependency-name: "net.javacrumbs.json-unit:*"
- versions: ["[3.0.0,)"]
Review Comment:
:+1: Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade `2.x` compiler baseline to Java 17 (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on PR #2021:
URL: https://github.com/apache/logging-log4j2/pull/2021#issuecomment-1835921585
> Some deps must however be downgraded, since tests must be runnable also on Java 8.
Thanks so much for the review, much appreciated! :pray: I have reverted test dependency upgrades. I will merge the changes sometime today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org