You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/24 06:42:41 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5176: Make
text index query cache a configurable option
codecov-io edited a comment on issue #5176: Make text index query cache a configurable option
URL: https://github.com/apache/incubator-pinot/pull/5176#issuecomment-603045784
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5176?src=pr&el=h1) Report
> Merging [#5176](https://codecov.io/gh/apache/incubator-pinot/pull/5176?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/b8ed426b6ac47d38279be4edad6956d7e8f00c51&el=desc) will **increase** coverage by `9.39%`.
> The diff coverage is `70.58%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5176?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5176 +/- ##
============================================
+ Coverage 56.52% 65.92% +9.39%
Complexity 12 12
============================================
Files 1052 1052
Lines 54170 54175 +5
Branches 8078 8081 +3
============================================
+ Hits 30620 35713 +5093
+ Misses 21118 15815 -5303
- Partials 2432 2647 +215
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../core/segment/index/loader/IndexLoadingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9JbmRleExvYWRpbmdDb25maWcuamF2YQ==) | `75.23% <33.33%> (+9.52%)` | `0.00 <0.00> (ø)` | |
| [...ment/index/readers/text/LuceneTextIndexReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvdGV4dC9MdWNlbmVUZXh0SW5kZXhSZWFkZXIuamF2YQ==) | `67.34% <40.00%> (-4.40%)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/pinot/common/config/FieldConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0ZpZWxkQ29uZmlnLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `69.24% <100.00%> (+20.55%)` | `0.00 <0.00> (ø)` | |
| [...ent/index/column/PhysicalColumnIndexContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2NvbHVtbi9QaHlzaWNhbENvbHVtbkluZGV4Q29udGFpbmVyLmphdmE=) | `93.33% <100.00%> (+5.49%)` | `0.00 <0.00> (ø)` | |
| [...core/segment/index/loader/SegmentPreProcessor.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9TZWdtZW50UHJlUHJvY2Vzc29yLmphdmE=) | `85.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...x/loader/defaultcolumn/V1DefaultColumnHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9kZWZhdWx0Y29sdW1uL1YxRGVmYXVsdENvbHVtbkhhbmRsZXIuamF2YQ==) | `83.33% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...x/loader/defaultcolumn/V3DefaultColumnHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9kZWZhdWx0Y29sdW1uL1YzRGVmYXVsdENvbHVtbkhhbmRsZXIuamF2YQ==) | `84.00% <100.00%> (+8.00%)` | `0.00 <0.00> (ø)` | |
| [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0.00%> (-7.15%)` | `0.00% <0.00%> (ø%)` | |
| [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `88.07% <0.00%> (+0.45%)` | `0.00% <0.00%> (ø%)` | |
| ... and [320 more](https://codecov.io/gh/apache/incubator-pinot/pull/5176/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5176?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5176?src=pr&el=footer). Last update [b8ed426...6dcae80](https://codecov.io/gh/apache/incubator-pinot/pull/5176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org